Skip to content

Add filters to remaining Dashboard FinOps grids#616

Merged
erikdarlingdata merged 1 commit intodevfrom
fix/dashboard-remaining-filters
Mar 18, 2026
Merged

Add filters to remaining Dashboard FinOps grids#616
erikdarlingdata merged 1 commit intodevfrom
fix/dashboard-remaining-filters

Conversation

@erikdarlingdata
Copy link
Owner

@erikdarlingdata erikdarlingdata commented Mar 18, 2026

Summary

  • Add column filter buttons to IdleDatabasesDataGrid (4 columns: DatabaseName, TotalSizeMb, FileCount, LastExecutionTime)
  • Add column filter buttons to TempdbPressureDataGrid (4 columns: Metric, CurrentMb, Peak24hMb, Warning)
  • Add column filter buttons to IndexAnalysisSummaryGrid (28 columns)
  • Add column filter buttons to IndexAnalysisDetailGrid (15 columns)

All use the existing FinOpsFilter_Click handler and ColumnFilterButtonStyle. Existing ElementStyle properties (right-alignment, tooltips) preserved on all columns.

Test plan

  • Open FinOps > Optimization tab, verify IdleDatabases and TempDB grids show filter buttons
  • Open FinOps > Index Analysis tab, verify both Summary and Detail grids show filter buttons
  • Click filter buttons, confirm filter popup works and filters data correctly
  • Verify right-aligned numeric columns still align correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added interactive filter buttons to column headers across all FinOps Dashboard tabs, enabling users to filter data directly from headers for improved usability.
  • UI/Style

    • Redesigned column headers with a unified structure combining filter controls and bold labels for consistency across multiple dashboard sections including Recommendations, Utilization, Database Resources, and Storage Analysis.

Add column filter buttons (FinOpsFilter_Click + ColumnFilterButtonStyle) to the
remaining 4 FinOps DataGrids that were missing them: IdleDatabasesDataGrid (4 cols),
TempdbPressureDataGrid (4 cols), IndexAnalysisSummaryGrid (28 cols), and
IndexAnalysisDetailGrid (15 cols). All existing ElementStyle properties preserved.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit b0c1b2a into dev Mar 18, 2026
3 checks passed
@erikdarlingdata erikdarlingdata deleted the fix/dashboard-remaining-filters branch March 18, 2026 00:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4e2a1a91-eb45-42ff-b631-a69e2b2d814f

📥 Commits

Reviewing files that changed from the base of the PR and between e858436 and 9269347.

📒 Files selected for processing (1)
  • Dashboard/Controls/FinOpsContent.xaml

📝 Walkthrough

Walkthrough

A XAML file is updated to replace simple column header text with composite headers containing filter buttons and bold TextBlock labels across multiple DataGrids in various sub-tabs, enabling per-column filtering capability.

Changes

Cohort / File(s) Summary
FinOps DataGrid Header Standardization
Dashboard/Controls/FinOpsContent.xaml
Replaces plain text headers with composite headers (filter Button + bold TextBlock) across columns in multiple DataGrids (Recommendations, Utilization, Database Resources, Storage Growth, Database Sizes, Index Analysis, Optimization, High Impact, Application Connections, Server Inventory, etc.). Each filter button is wired to FinOpsFilter_Click handler with a Tag binding to the column's data property.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add column filters to FinOps grids #614: Implements the FinOpsFilter_Click handler, filter popup logic, and per-grid filter state management that directly supports the new filter button headers introduced in this PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dashboard-remaining-filters
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant