Add filters to remaining Dashboard FinOps grids#616
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 18, 2026
Merged
Conversation
Add column filter buttons (FinOpsFilter_Click + ColumnFilterButtonStyle) to the remaining 4 FinOps DataGrids that were missing them: IdleDatabasesDataGrid (4 cols), TempdbPressureDataGrid (4 cols), IndexAnalysisSummaryGrid (28 cols), and IndexAnalysisDetailGrid (15 cols). All existing ElementStyle properties preserved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA XAML file is updated to replace simple column header text with composite headers containing filter buttons and bold TextBlock labels across multiple DataGrids in various sub-tabs, enabling per-column filtering capability. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All use the existing
FinOpsFilter_Clickhandler andColumnFilterButtonStyle. ExistingElementStyleproperties (right-alignment, tooltips) preserved on all columns.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
UI/Style