Fix File I/O chart 'Unknown' labels (#633)#636
Merged
erikdarlingdata merged 3 commits intodevfrom Mar 19, 2026
Merged
Conversation
- llms.txt: structured project summary for LLM crawlers (llmstxt.org standard) - CITATION.cff: enables GitHub "Cite this repository" widget + structured metadata Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Removed CROSS APPLY sys.dm_exec_plan_attributes and the direct sys.databases join. Both dm_exec_plan_attributes and dm_exec_sql_text can trigger severity 22 engine crashes when plan handles reference RESTORING databases on passive mirror servers. Now pre-builds a temp table of ONLINE, accessible database IDs (filtered by state = 0 + HAS_DBACCESS) before the main query runs. The staging INSERT joins to this temp table instead of sys.databases, preventing any DMV from being evaluated against RESTORING databases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When sys.master_files LEFT JOIN misses (NULL file_name), fall back to
DB_{database_id} and File_{file_id} instead of generic 'Unknown'.
Chart labels now show e.g. 'MyDatabase.File_2' instead of
'MyDatabase.Unknown'.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to DB_{id} and File_{id} instead of generic 'Unknown' when sys.master_files LEFT JOIN misses.