Fix webhook alert recording and delivery tracking#726
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 27, 2026
Merged
Conversation
…ok delivery
Dashboard: move RecordAlert back inside SMTP block to prevent duplicate
"tray" entries when email is disabled. Add separate "webhook" record
when webhook notifications are delivered.
Lite: capture webhook send result and reflect in notification_type
column ("webhook" or "email+webhook") in DuckDB alert log.
Both: change TrySendWebhookAlertsAsync return type to Task<bool> so
callers can act on delivery status.
Follows up on #725.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordAlertback inside the SMTP block so it only fires when an email is actually attempted — eliminates duplicate "tray" entries introduced by feature/Add Teams and Slack webhook notifications #725 when SMTP is disabled. Adds a separate "webhook" record when Teams/Slack notifications are delivered.notification_typecolumn ("webhook"when only webhooks sent,"email+webhook"when both).TrySendWebhookAlertsAsyncreturn type fromTasktoTask<bool>so callers can act on delivery status.Follows up on #725.
Test plan
notification_typeshould be "webhook"notification_typeshould be "email+webhook"🤖 Generated with Claude Code