Skip to content

Fix Lite FinOps Enterprise features query for missing database_id column #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Apr 2, 2026
Merged

Fix Lite FinOps Enterprise features query for missing database_id column #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions Lite/Services/LocalDataService.FinOps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,11 +1569,18 @@ public async Task<List<RecommendationRow>> GetRecommendationsAsync(int serverId,

if (edition.Contains("Enterprise", StringComparison.OrdinalIgnoreCase))
{
using var featCmd = new SqlCommand(@"
SELECT
DB_NAME(database_id) AS database_name,
feature_name
FROM sys.dm_db_persisted_sku_features", sqlConn);
var hasDatabaseId = false;
using (var colCheck = new SqlCommand(
"SELECT COL_LENGTH('sys.dm_db_persisted_sku_features', 'database_id')", sqlConn))
{
colCheck.CommandTimeout = 10;
hasDatabaseId = await colCheck.ExecuteScalarAsync() is not null and not DBNull;
}

var featSql = hasDatabaseId
? "SELECT DB_NAME(database_id) AS database_name, feature_name FROM sys.dm_db_persisted_sku_features"
: "SELECT N'(unknown)' AS database_name, feature_name FROM sys.dm_db_persisted_sku_features";
using var featCmd = new SqlCommand(featSql, sqlConn);
featCmd.CommandTimeout = 30;

var features = new List<string>();
Expand Down
Loading