Fix CLI installer argument parsing treating flags as positional args#787
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 4, 2026
Merged
Fix CLI installer argument parsing treating flags as positional args#787erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
Flags like --encrypt optional (space-separated) were not fully stripped from positional arguments, causing the installer to misinterpret them as a username and fall into the SQL Auth path unexpectedly. Replace individual flag filters with a single loop that strips all -- prefixed flags and consumes trailing values for --entra and --encrypt. Also support --encrypt <level> (space) in addition to --encrypt=<level>. Fixes #786 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--encrypt optional(space-separated) weren't fully stripped from positional args, causing the installer to treat them as a username and fall into the SQL Auth path--prefixed flags and consumes trailing values for--entraand--encrypt--encrypt=optionaland--encrypt optionalFixes #786
Test plan
SERVERNAME --trust-cert --encrypt=optional→ 1 positional arg → Windows AuthSERVERNAME --trust-cert --encrypt optional→ 1 positional arg → Windows AuthSERVERNAME sa password --trust-cert→ 3 positional args → SQL Auth🤖 Generated with Claude Code