Fix legend duplication on tab switch#841
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 15, 2026
Merged
Conversation
…leanupOnClose WPF fires Unloaded on tab switch, not just destruction. The old handler tore down legend tracking, chart helpers, and event subscriptions on every tab switch, causing the auto-refresh loop to lose track of legend panels and create duplicates. Now Unloaded is a no-op; full cleanup only runs via CleanupOnClose when a tab is actually closed/removed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move teardown logic from
ServerTab_Unloadedto a newCleanupOnClosemethod. WPF firesUnloadedon tab switch (not just destruction), which was clearing_legendPanels, disposing chart helpers, and unsubscribing events while the auto-refresh loop was still running. This caused duplicate legends on every tab switch.Now
Unloadedis a no-op.CleanupOnCloseis called fromMainWindowonly when a tab is actually closed/removed.Test plan
🤖 Generated with Claude Code