Harden DuckDB queries and fix IsArchiving race condition#850
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 15, 2026
Merged
Harden DuckDB queries and fix IsArchiving race condition#850erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
…ving race Addresses security findings from #840: - #846: Escape single quotes in file paths interpolated into read_parquet() and COPY TO - #847: Use DuckDB $1 parameters for DateTime values instead of string interpolation - #849: Make IsArchiving volatile-backed to prevent stale reads across threads Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_parquet()andCOPY TO— 9 call sites inArchiveService.csandDuckDbInitializer.cs$1parameters in 3 queries (DELETE,COUNT,COPY)IsArchivingvolatile-backed to prevent stale reads across threadsShared
EscapeSqlPath()helper lives onDuckDbInitializer(internal static), delegated fromArchiveService.Closes #846, closes #847, closes #849
Test plan
🤖 Generated with Claude Code