Skip to content

Fix FinOps TDE recommendation on SQL Server 2019+#855

Merged
erikdarlingdata merged 1 commit intodevfrom
fix/854-finops-tde-version-awareness
Apr 16, 2026
Merged

Fix FinOps TDE recommendation on SQL Server 2019+#855
erikdarlingdata merged 1 commit intodevfrom
fix/854-finops-tde-version-awareness

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • Fixes [BUG] FinOps Recommendations report no Enterprise-only features on servers with TDE-enabled databases #854 — FinOps Recommendations falsely reported "no databases use TDE" on SQL Server 2019, 2022, and 2025 even when TDE was enabled
  • Root cause: sys.dm_db_persisted_sku_features correctly does not report TDE on 2019+ because TDE moved to Standard Edition in that release. The recommendation logic and messaging assumed TDE was always Enterprise-only.
  • Added ProductMajorVersion check: on 2019+ (major version >= 15), skips the TDE-specific DMV check and instead shows version-appropriate guidance that most features are now available in Standard Edition
  • Pre-2019 behavior is preserved unchanged

Test plan

  • Verify on SQL 2019/2022/2025 Enterprise: recommendation shows "Enterprise Edition may not be required" with correct messaging
  • Verify on SQL 2016/2017 Enterprise (if available): original TDE detection behavior still works
  • Verify non-Enterprise editions skip the check entirely (existing behavior, unchanged)

🤖 Generated with Claude Code

TDE moved to Standard Edition in SQL 2019, so dm_db_persisted_sku_features
no longer reports it as Enterprise-only. Add version check to give
version-appropriate licensing guidance instead of falsely claiming no
databases use TDE.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 2b67f09 into dev Apr 16, 2026
3 checks passed
@erikdarlingdata erikdarlingdata deleted the fix/854-finops-tde-version-awareness branch April 19, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant