Fix FinOps TDE recommendation on SQL Server 2019+#855
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 16, 2026
Merged
Conversation
TDE moved to Standard Edition in SQL 2019, so dm_db_persisted_sku_features no longer reports it as Enterprise-only. Add version check to give version-appropriate licensing guidance instead of falsely claiming no databases use TDE. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.dm_db_persisted_sku_featurescorrectly does not report TDE on 2019+ because TDE moved to Standard Edition in that release. The recommendation logic and messaging assumed TDE was always Enterprise-only.ProductMajorVersioncheck: on 2019+ (major version >= 15), skips the TDE-specific DMV check and instead shows version-appropriate guidance that most features are now available in Standard EditionTest plan
🤖 Generated with Claude Code