Skip to content

Skip live query plans on Azure SQL DB (#857)#871

Merged
erikdarlingdata merged 1 commit intodevfrom
fix/857-no-live-plan-azure
Apr 21, 2026
Merged

Skip live query plans on Azure SQL DB (#857)#871
erikdarlingdata merged 1 commit intodevfrom
fix/857-no-live-plan-azure

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

Third follow-up to #857. @TrudAX confirmed the #temp pre-filter from #869 didn't resolve the Live Snapshot error for his D365FO database — same SQL 300 (VIEW SERVER PERFORMANCE STATE permission was denied).

His working SSMS query uses sys.dm_exec_sql_text and sys.dm_exec_query_plan but not sys.dm_exec_query_statistics_xml — that's the signal. Per MS docs, sys.dm_exec_query_statistics_xml requires VIEW SERVER PERFORMANCE STATE on Azure SQL Database regardless of service tier or scope. Even with the #temp pre-filter only feeding it current-DB session IDs, the DMF does a server-level permission check before returning, so it fails for DB-scoped logins.

Fix: disable live query plans on Azure SQL Database in both the collector and the Live Snapshot button. Users lose the animated in-progress query plan on Azure SQL DB but get working current-activity visibility — which they don't have at all today. Boxed SQL Server and Azure Managed Instance (edition 8) still get live plans.

  • CollectQuerySnapshotsAsync: supportsLiveQueryPlan = !isAzureSqlDatabase && (version >= 13 || version == 0 || edition == 8)
  • LiveSnapshot_Click: pass !_isAzureSqlDatabase instead of hardcoded true
  • No SQL template changes — when supportsLiveQueryPlan is false the existing BuildQuerySnapshotsQuery already emits live_query_plan = CONVERT(xml, NULL), and omits the OUTER APPLY

Test plan

  • Build: dotnet build Lite/PerformanceMonitorLite.csproj -c Debug — 0 errors
  • Boxed SQL Server smoke test (SQL2022): live plans still emitted, behaviour unchanged
  • D365FO confirmation (deferred to @TrudAX): Live Snapshot returns rows without the permission error; live_query_plan column will be NULL on Azure SQL DB

🤖 Generated with Claude Code

sys.dm_exec_query_statistics_xml requires VIEW SERVER PERFORMANCE
STATE on Azure SQL Database regardless of scope, so DB-scoped logins
(e.g. D365FO) still hit error 300 even after the #temp pre-filter
landed in #869. The OUTER APPLY evaluates the DMF for every session
in #req and fails on the permission check before returning rows.

Force supportsLiveQueryPlan=false for SqlEngineEdition=5 in both the
collector and the Live Snapshot button paths. Boxed SQL Server and
Azure MI (edition 8) still get live plans as before.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Owner Author

@erikdarlingdata erikdarlingdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this PR does

Disables sys.dm_exec_query_statistics_xml (the live in-progress plan DMF) on Azure SQL Database in the Lite collector and the Live Snapshot button. On Azure SQL DB the DMF requires VIEW SERVER PERFORMANCE STATE, which DB-scoped logins (D365FO and similar) don't hold; the DMF performs a server-level permission check before honoring the per-session filter, so the #temp pre-filter from #869 didn't help. The fallback path in BuildQuerySnapshotsQuery already emits live_query_plan = CONVERT(xml, NULL) and drops the OUTER APPLY, so no SQL template change is needed.

Good

  • Targets dev
  • No PlanAnalyzer.cs changes — Dashboard/Lite sync not at risk
  • No SQL/install/upgrade changes — no upgrade-script concern
  • Lite-only fix (Dashboard's collectors are SQL Agent jobs, not affected)
  • No .github/workflows/build.yml changes — SignPath policy unchanged
  • Comment block at Lite/Services/RemoteCollectorService.QuerySnapshots.cs:220-227 explains the why with issue reference; that's the kind of comment that earns its keep
  • LiveSnapshot_Click is async void but it's a routed event handler — fine
  • Boxed (version >= 13), unknown version (== 0), and Azure Managed Instance (edition 8) still get live plans; correctly preserved

Needs attention

  • Duplicated gating predicate. See inline at Lite/Controls/ServerTab.xaml.cs:5370 — the click handler and the collector each compute supportsLiveQueryPlan independently. They agree today but are easy to drift. A RemoteCollectorService.SupportsLiveQueryPlan(ConnectionStatus) helper would keep them honest.
  • Behaviour change vs. previous code at Lite/Services/RemoteCollectorService.QuerySnapshots.cs:231 — the old expression had || SqlEngineEdition == 5, i.e. Azure SQL DB was explicitly enabled. Now unconditionally disabled. Right call for the #857 cohort, but removes the capability for any Azure SQL DB login that did hold VIEW SERVER PERFORMANCE STATE. Worth confirming with @TrudAX (deferred test in PR description) before this lands.
  • No test coverage. Lite.Tests has no tests covering BuildQuerySnapshotsQuery or the gating predicate. This logic has now changed three times for #857 (#869, #870, #871) — a small unit test that asserts the column/APPLY emission for (supportsLiveQueryPlan, isAzureSqlDatabase) matrix would have caught any regression and is cheap to add.
  • Related, not in scope: Dashboard's Dashboard/Services/DatabaseService.QueryPerformance.cs:3556 issues sys.dm_exec_query_statistics_xml unconditionally for the live-queries view, with no Azure-DB awareness. Dashboard normally connects to a centralized PerformanceMonitor DB on boxed SQL, so this likely isn't hit in practice — but if a Dashboard install ever points at an Azure SQL DB instance with a DB-scoped login, it will reproduce #857 there. Worth a follow-up issue, not a blocker for this PR.

Generated by Claude Code

var isAzureSqlDatabase = serverStatus.SqlEngineEdition == 5;
var supportsLiveQueryPlan = !isAzureSqlDatabase
&& (serverStatus.SqlMajorVersion >= 13 || serverStatus.SqlMajorVersion == 0
|| serverStatus.SqlEngineEdition == 8);
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaviour change worth calling out: previously SqlEngineEdition == 5 (Azure SQL DB) explicitly enabled live plans (the old expression OR'd EngineEdition == 5). After this change Azure SQL DB is unconditionally excluded — including service-tier/login combos where VIEW SERVER PERFORMANCE STATE is held (some elastic admin / server-admin logins can grant it). That's almost certainly the right tradeoff given #857, but it removes the capability for the small set of Azure SQL DB users who weren't broken before. The PR description's deferred test on D365FO is the right gate.


Generated by Claude Code

var query = RemoteCollectorService.BuildQuerySnapshotsQuery(supportsLiveQueryPlan: true, isAzureSqlDatabase: _isAzureSqlDatabase);
// Live query plans require VIEW SERVER PERFORMANCE STATE on Azure SQL DB,
// which DB-scoped logins don't have — skip them there. See #857.
var query = RemoteCollectorService.BuildQuerySnapshotsQuery(supportsLiveQueryPlan: !_isAzureSqlDatabase, isAzureSqlDatabase: _isAzureSqlDatabase);
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gating logic now lives in two places — here and RemoteCollectorService.QuerySnapshots.cs:231. They agree today (!isAzureSqlDatabase), but the collector also factors version/edition (>= 13 || == 0 || == 8) while this caller only checks Azure. If the collector's predicate gets tighter later (e.g. excludes some other engine edition), this site won't follow. Consider exposing a single RemoteCollectorService.SupportsLiveQueryPlan(serverStatus) helper so both sites share the rule.


Generated by Claude Code

@erikdarlingdata erikdarlingdata merged commit 3327c91 into dev Apr 21, 2026
3 checks passed
@erikdarlingdata erikdarlingdata deleted the fix/857-no-live-plan-azure branch April 21, 2026 15:18
erikdarlingdata added a commit that referenced this pull request Apr 22, 2026
* Implements #843 in Lite

* Implements #843 for Full Dashboard

* Add trailing newlines to ScrollPanBehavior files

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Harden DuckDB queries: parameterize values, escape paths, fix IsArchiving race

Addresses security findings from #840:
- #846: Escape single quotes in file paths interpolated into read_parquet() and COPY TO
- #847: Use DuckDB $1 parameters for DateTime values instead of string interpolation
- #849: Make IsArchiving volatile-backed to prevent stale reads across threads

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Encrypt webhook URLs with DPAPI via Windows Credential Manager

Moves Teams and Slack webhook URLs from plaintext settings.json/preferences.json
to Windows Credential Manager (DPAPI-encrypted), matching the existing pattern
used for SMTP passwords and SQL Server credentials.

Includes automatic migration: on first settings load, any plaintext URLs are
moved to Credential Manager and removed from the JSON file.

Closes #848

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Lazy-load server tabs: only load visible tab on open, full-load on first visit

Initial tab open and Refresh button now only load the currently visible tab.
First switch to any tab triggers a full refresh of that tab (all sub-tabs).
Subsequent refreshes only hit the active sub-tab.

Ctrl+Click on Refresh Tab (or Ctrl+F5) refreshes all tabs at once.
Apply to All Tabs retains existing full-refresh behavior.

Fixes #835 — prevents heavy queries (e.g. GetQueryStatsAsync) from running
on tab open when the user is only viewing Overview.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Cap query/procedure/query store grid results to TOP 500

GetQueryStatsAsync, GetProcedureStatsAsync, and GetQueryStoreDataAsync
were returning unbounded result sets. With 49 databases and 742K rows
in query_stats over 3 days, the GROUP BY with plan XML could produce
thousands of rows and timeout after 120 seconds.

TOP 500 ordered by avg CPU desc is plenty for a grid view and prevents
the query from consuming unbounded memory on large installations.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove pointless WAITFOR DECOMPRESS filters from stats/store queries

The CAST(DECOMPRESS(...)) NOT LIKE N'WAITFOR%' filter was decompressing
query text on every row in query_stats and query_store_data just to skip
WAITFOR queries. WAITFOR has no plan and no meaningful stats — it only
matters in query snapshots (active sessions), where the filter remains.

On a 742K-row query_stats table, this was a significant contributor to
the 120-second query timeouts reported in #835.

The snapshot filters (report.query_snapshots) and MCP phased queries
are untouched — they filter after TOP on already-hydrated text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Refactor query/procedure/query store stats to phased DECOMPRESS approach

All three grid queries now use a 3-phase pattern:
1. Aggregate numerics into temp table (no DECOMPRESS)
2. Sum across lifetimes, rank TOP 500
3. OUTER APPLY to decompress text/plan for only the 500 winners

On a 742K-row query_stats table, this reduces DECOMPRESS calls from
742K to 500 — eliminating the 16+ minute query times reported in #835.

Matches the existing phased pattern used by the MCP query tools.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix FinOps TDE recommendation on SQL Server 2019+ (#854)

TDE moved to Standard Edition in SQL 2019, so dm_db_persisted_sku_features
no longer reports it as Enterprise-only. Add version check to give
version-appropriate licensing guidance instead of falsely claiming no
databases use TDE.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Sync PlanAnalyzer and BenefitScorer from PerformanceStudio (Apr 9-16)

Port PS PRs #216, #217, #219, #224, #229, #230, #231 to PM.

PlanAnalyzer changes:
- Rule 5: Suppress for Key Lookups (point lookups mislead per-execution estimates)
- Rule 8: Enhanced parallel skew with batch mode sort detection and practical context
- Rule 9: Large memory grant shows top 3 consumers sorted by row count
- Rule 10: Key lookup overhaul — show output columns, check predicate filtering, softer advice
- Rules 11/12/29: Suppress on 0-execution nodes (operator never ran)
- Rule 11: I/O wait severity elevation when scan hits disk
- Rule 24: FormatNodeRef helper includes object name for data access operators
- Rule 26: Suppress when row goal prediction was correct, specific cause detection
- Wait stats: DescribeWaitType with full wait type coverage, multi-wait summary
- New helpers: GetWaitLabel, HasSignificantIoWaits, IdentifyRowGoalCause, FormatNodeRef
- GetOperatorOwnElapsedMs changed to internal for BenefitScorer access

BenefitScorer (new file):
- Stage 1: MaxBenefitPercent for operator-level rules (filter, spill, lookup, etc.)
- Stage 2: Wait stats benefit scoring with parallel allocation (Joe's formula)

PlanModels additions:
- MaxBenefitPercent and ActionableFix on PlanWarning
- WaitBenefit class and WaitBenefits list on PlanStatement

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fall back to single-database mode when Azure master is inaccessible (#857)

On Azure SQL DB, some logins (e.g. Microsoft Dynamics 365 FO) are granted
access only to a specific user database and not to master. The three
collectors that enumerate databases via master — query_stats,
database_size_stats, file_io_stats — would fail the first time and
produce an empty screen.

GetAzureDatabaseListAsync now catches known access-denied/login-failed
errors from the master connection, caches the per-server decision, and
returns the connection's InitialCatalog as a single-element list. The
three callers already loop per-database, so single-DB mode works without
further changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Add nonclustered indexes for query/procedure/query store lookups

Phase 3 OUTER APPLY hydration of compressed query_text/plan_text was forcing
an Eager Index Spool over the full collect.query_stats table (and similar
for procedure_stats / query_store_data), which took 104 seconds on a
742K-row table in #835.

Changes:
- Remove CONVERT(binary(8), nvarchar-hash, 1) anti-pattern from OUTER APPLY
  WHERE clauses by keeping query_hash as native binary(8) in temp tables.
  query_hash is only converted to nvarchar(20) in the final output projection.
- Add three nonclustered indexes (install script and upgrade script):
    IX_query_stats_hash_lookup (query_hash, database_name, collection_time DESC)
    IX_procedure_stats_name_lookup (database_name, schema_name, object_name, collection_time DESC)
    IX_query_store_data_id_lookup (database_name, query_id, collection_time DESC)
- Indexes use SORT_IN_TEMPDB = ON and DATA_COMPRESSION = PAGE.
- ONLINE = ON is applied conditionally via dynamic SQL based on
  SERVERPROPERTY('EngineEdition') — Enterprise/Developer/Azure only, since
  Standard/Web/Express don't support online index operations.

Tested against CADelete's 742K-row table: Phase 3 went from 104s to
well under 1s (5s total for the full three-phase query).

Fixes #835

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Scope query snapshots to current database on Azure SQL DB (#857)

On Azure SQL Database, logins without access to master can't resolve
cross-database rows returned by sys.dm_exec_requests, which caused the
Live Snapshot button and the query snapshots collector to error in
D365FO-style environments (reported by @TrudAX in #857 after PR #858).

BuildQuerySnapshotsQuery now takes an isAzureSqlDatabase flag and emits
AND der.database_id = DB_ID() only when true. Boxed SQL Server, MI, and
elastic pool behavior is unchanged. The Live Snapshot button path gets
the flag through a new ServerTab constructor parameter wired from the
cached ServerConnectionStatus.SqlEngineEdition.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Polish Lite chart axes and sub-tab styling

- Chart X-axis prints the date line only on the first tick and on ticks
  where the date changes; all other ticks show time only. Format respects
  current culture (en-GB → dd/MM, de-DE → dd.MM, 24h clocks, etc.).
  Implemented as a DateTimeTicksBottomDateChange() extension in
  Lite/Helpers/AxesExtensions.cs and applied to every DateTimeTicksBottom
  call site in ServerTab and CorrelatedTimelineLanesControl.
- Server name no longer duplicated in the ServerTab header status line;
  ConnectionStatusText now shows just "Connecting..." / "Last refresh: ...".
- Chart tick label font bumped from 12 to 13 for readability.
- New SubTabItemStyle (thin accent underline, transparent background) in
  all three themes, applied to Queries / Memory / File I/O / Blocking /
  Perfmon / Running Jobs sub-TabControls so sub-tab selection no longer
  looks identical to main-tab selection.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Port Lite chart/tab polish to Dashboard + LSP diagnostics cleanup

Dashboard polish (ports the same items merged to Lite in #862):
- New Dashboard/Helpers/AxesExtensions.cs with DateTimeTicksBottomDateChange(),
  culture-aware (dd/MM for en-GB, dd.MM for de-DE, 24h clocks, etc.). All 52
  call sites of DateTimeTicksBottom() across 10 files swapped to use it.
- TabHelpers.ApplyTheme + ReapplyAxisColors bump chart tick label font from
  12 to 13 so numbers read cleaner on wide charts.
- SubTabItemStyle added to Dark / Light / CoolBreeze themes: thin accent
  underline + transparent background instead of filled cyan, so sub-tabs
  don't look identical to main tabs when selected. Wired via
  ItemContainerStyle on 11 sub-TabControls (Overview's inner tabs,
  Collection Health's inner tabs, Locking, ConfigChanges, CurrentConfig,
  FinOps, Memory, ResourceMetrics ×2, SystemEvents, QueryPerformance).

LSP diagnostics cleanup (tracked work from chore/lsp-diagnostics-cleanup):
- Small nullability/warning fixes across Dashboard and Lite services,
  analysis helpers, and BenefitScorer / PlanAnalyzer.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix Overview crosshair disappearing after tab switches / layout passes

Root cause: the control wired `Unloaded += ...Dispose()` on the crosshair
manager, and WPF fires Unloaded for transient reasons (tab virtualization,
layout rebuilds, etc.), not just when the control is actually going away.
Dispose() clears the manager's lane list, after which ReattachVLines runs
over an empty list and the crosshair is gone permanently.

Changes:
- Remove the Unloaded → Dispose() handler in both Lite and Dashboard copies.
  The manager holds only managed state (a Popup + lane references) — GC
  will clean it up with the control.
- Remove the now-redundant `_isRefreshing` flag from CorrelatedCrosshairManager.
  The `lane.VLine == null` check in OnMouseMove is a sufficient "not ready"
  guard and is self-healing once VLines are recreated.
- Wrap ReattachVLines in a try/finally on the control side, with a new
  idempotent EnsureVLinesAttached() safety net that only creates VLines
  for lanes where they're still null.
- Make CreateVLine catch per-lane exceptions so one failing chart can't
  prevent the others from recovering.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix Memory Pressure Events chart filter; add MCP interpretation (#865)

Chart previously filtered to HIGH severity only (indicator>=3), which on most
servers never fires, producing an empty chart even when sp_pressuredetector-
level medium pressure (indicator=2) was occurring constantly. Switch to stacked
bars per hour, split by SQL Server (process) vs Operating System (system), with
severe events capped on top of medium in a darker shade. Extend ChartHoverHelper
to support BarPlot tooltips. Add MCP guidance for interpreting indicator values
and routing to the right follow-up tool.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Port Memory Pressure Events feature to Lite (#865)

Lite was missing the RING_BUFFER_RESOURCE_MONITOR collector entirely — no
collector, no table, no chart, no MCP tool. This adds the full feature:

- Schema: new memory_pressure_events table + index, schema v25, added to
  ArchivableTables, server-id-fix list, and ArchiveService.
- Collector: CollectMemoryPressureEventsAsync queries the ring buffer and
  client-side-dedupes against DuckDB's MAX(sample_time). Azure SQL DB returns
  zero rows (ring buffer not exposed there). Scheduled every 5 min (Aggressive
  and Balanced presets) or 15 min (Low-Impact).
- UI: new 'Memory Pressure Events' sub-tab on the Memory tab with the same
  stacked-bar chart as Dashboard (SQL Server medium/severe, Operating System
  medium/severe). Wired into full-load and sub-tab-switch refresh paths.
- Hover: ported the BarPlot support from Dashboard's ChartHoverHelper so bar
  tooltips work and report the correct segment height for stacked bars.
- MCP: new get_memory_pressure_events tool + the 'Interpreting Memory
  Pressure Events' guidance section in McpInstructions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Bump schema table count test to 30 for memory_pressure_events

Companion update to the new memory_pressure_events table added in this PR.
SchemaStatements_MatchTableCount asserts the total table count; needs to
move from 29 to 30 to reflect the new table.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix blocked process report plan lookup (#867) (#868)

Right-click > View Plan on a Blocked Process Reports row silently fell
through (no handler case) and Get Actual Plan erred with "no query text."

- Split the grid onto its own BlockedProcessContextMenu with separate
  View Blocked Plan / View Blocking Plan actions; drop Get Actual Plan
  (re-executing a mid-transaction blocked query is a foot-gun).
- Parse all <frame> entries from the BPR XML's executionStack, filter
  the 42-byte all-zero sql_handle placeholder (dynamic SQL / system
  context), default stmtstart=0 / stmtend=-1 per the dm_exec_text_query_plan
  convention. Matches sp_HumanEventsBlockViewer's XPath and join shape.
- Add FetchPlanBySqlHandleAsync keyed on sql_handle + statement offsets
  against sys.dm_exec_query_stats. Caller iterates frames until one
  resolves; falls back to a clear "plan no longer in cache" message.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Pre-filter query snapshot requests into #temp on Azure SQL DB (#857) (#869)

Follow-up to #861. The DB_ID() predicate in the WHERE clause wasn't
enough — the OUTER APPLYs to sys.dm_exec_sql_text and
sys.dm_exec_text_query_plan were still being evaluated against
master-scoped rows from sys.dm_exec_requests before the filter was
applied, tripping VIEW SERVER PERFORMANCE STATE errors for DB-scoped
logins (D365FO). A CTE or derived table wouldn't guarantee the
filter order, so materialise the filtered request rows into #req
first and drive the DMFs off that.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Stop retrying collectors after non-transient permission denial (#857) (#870)

The collector loop already classifies SQL errors 229 / 297 / 300 as
PERMISSIONS status and excludes them from the failure rate, but it
keeps re-running the collector every interval and logging an
identical denial each time. For DB-scoped logins on Azure SQL DB
(e.g. D365FO) this churns the collection log and gives no new
information — the permission won't change mid-session.

Flag the collector on first denial and short-circuit RunCollectorAsync
so we don't make the round-trip or the log entry. Flag is in-memory
per (server, collector) — cleared on app restart so newly granted
permissions are picked up on the next launch.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Skip live query plans on Azure SQL DB (#857) (#871)

sys.dm_exec_query_statistics_xml requires VIEW SERVER PERFORMANCE
STATE on Azure SQL Database regardless of scope, so DB-scoped logins
(e.g. D365FO) still hit error 300 even after the #temp pre-filter
landed in #869. The OUTER APPLY evaluates the DMF for every session
in #req and fails on the permission check before returning rows.

Force supportsLiveQueryPlan=false for SqlEngineEdition=5 in both the
collector and the Live Snapshot button paths. Boxed SQL Server and
Azure MI (edition 8) still get live plans as before.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix FinOps recommendation severity sort order (#872)

Sort recommendations by severity rank (High=1, Medium=2, Low=3)
instead of alphabetically. Adds SeveritySort property to
RecommendationRow and uses it as SortMemberPath for the Severity
column. Display strings are unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix FinOps severity sort order in Dashboard (#872)

Severity column was sorting alphabetically (High, Low, Medium) instead
of by severity ranking. Added SeveritySort computed property on
FinOpsRecommendation, ordered results by it, and wired the DataGrid
column's SortMemberPath so click-sort matches the default order.

Mirrors the Lite fix in PR #874.

* Drop sys.dm_os_schedulers from memory_stats on Azure SQL DB (#857) (#876)

Azure SQL Database DBs hosted in an elastic pool (notably D365FO
customer tenants) enforce VIEW SERVER PERFORMANCE STATE on
sys.dm_os_schedulers regardless of the login's DB-scoped grants —
VIEW DATABASE STATE + VIEW DATABASE PERFORMANCE STATE on the user DB
are not sufficient. Verified by reproducing the failure in a
standard Azure SQL DB elastic pool with a contained DB user; bare
sys.dm_exec_requests/sys.dm_os_sys_info/sys.dm_os_performance_counters
succeed but sys.dm_os_memory_clerks / sys.dm_os_schedulers /
sys.dm_os_waiting_tasks fail with error 300.

The other failing collectors (memory_clerks, waiting_tasks,
tempdb_stats) have no DB-scoped alternative and will stay skip-gated
via #870 for these users.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Release v2.8.0: version bumps and changelog (#877)

Adds nonclustered indexes to collect.query_stats, procedure_stats, and
query_store_data for Dashboard grid lookups (#835). Ports Memory Pressure
Events to Lite (#865). Multiple Azure SQL DB collector fixes (#857).
FinOps severity sort order fix (#872). Grid auto-scrolling (#843).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Scope v2.8.0 webhook DPAPI note to Dashboard (#879)

Lite webhook URLs still read from plaintext settings — avoids implying
the security hardening shipped to both editions.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: ClaudioESSilva <claudiosil100@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant