CI: fix paths-filter to compare against previous commit on push#928
Merged
erikdarlingdata merged 1 commit intodevfrom May 3, 2026
Merged
CI: fix paths-filter to compare against previous commit on push#928erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
dorny/paths-filter@v3 defaults to comparing against the default branch on push events to non-default branches, which made every push to dev match the lite_analysis filter (dev is ~1200 commits ahead of main). Set base explicitly to github.event.before for push events; leave it empty on pull_request so the action keeps its PR-base default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #927's path filter worked correctly on the PR build (compared against the PR base, dev) but fired the heavy Lite lane on the resulting dev push. Root cause from the run log:
```
Changes will be detected between main and dev
git merge-base refs/remotes/origin/main refs/remotes/origin/dev
Detected 106 changed files
```
dorny/paths-filter@v3 defaults to comparing against the default branch on push events to non-default branches. dev is ~1200 commits ahead of main, so every push effectively saw the entire backlog, including all the FinOps/LocalDataService work, and `lite_analysis = true`.
This sets `base: github.event.before` for push events explicitly, while leaving it empty on pull_request so the action keeps its PR-base default.
Expected behavior after this PR
Test plan
🤖 Generated with Claude Code