[BUG] : some icons could be improved in plans

[rferraton]

Component

Desktop App (Windows)

SQL Performance Studio Version

1.8.0

Operating System

all

Describe the Bug

Some plan nodes does not display a correct icon in the plan :

Node Type	Current Icon	Expected Icon
Parallelism (Repartition Streams)
Parallelism (Distribute Streams)
Columnstore Index Scan

Steps to Reproduce

get a plan with problematic nodes (see attachment)

Expected Behavior

aligned with SSMS icons

Actual Behavior

Some icons are missing in the PlanIcons directory like parallel distribute or repartition but others are in the PlanIcons directory but not used like columnstore ones

Plan File

plan_20260426_022706.xml

Screenshots

see bug description

[erikdarlingdata]

Looked into this. Two distinct issues:

Columnstore Index Scan — straightforward bug. The plan XML has PhysicalOp="Clustered Index Scan" with a child <Object Storage="ColumnStore" />, and our icon mapper only looks at PhysicalOp, so it picks clustered_index_scan.png. The columnstore_index_scan.png asset already exists in Resources/PlanIcons/, just unused. Fix: route to the columnstore icon when StorageType == "ColumnStore". I'll have a PR up for this shortly.

Parallelism (Repartition / Distribute / Gather Streams) — the existing PlanIcons set comes from microsoft/vscode-mssql (MIT). I checked their tree: they ship a single parallelism.png plus an overlay-parallelism.svg, and collapse all three subtypes to the same icon. They don't have distinct Repartition / Distribute / Gather icons, so we can't pull them from there.

The sqlserverfast.com icons in the issue are Hugo Kornelis's hand-drawn SSMS-style assets — different source, different licensing terms, not appropriate to relicense.

Going with the vscode-mssql approach: keep parallelism.png as the base and use the existing overlay-parallelism.svg-style overlay technique to differentiate the three subtypes via a small letter/marker (R / D / G) rendered on top. That's the responsible path that doesn't require sourcing assets we don't have rights to.

[rferraton]

Home made for the repo : MIT

Repartition Stream :

Distribute Stream :

[erikdarlingdata]

These are great, thank you so much — really appreciate you taking the time to draw them and license them MIT for the repo. The Repartition shuffle pattern and the Distribute fan-out both read clearly at small sizes and match the SSMS-style of the rest of the icon set.

One ask: could you also do a Gather Streams icon? It's the natural mirror of Distribute (many arrows on the left converging into one on the right), but a clean horizontal flip doesn't quite work — the arrowheads end up pointing the wrong way, so it really needs a fresh draw. Once we have all three, we can swap from the temporary R/D/G letter overlay to the real icons in a single PR.

Thanks again!

[erikdarlingdata]

@rferraton on second thought, I'm just going to mirror Distribute Streams and use it as Gather Streams.

[erikdarlingdata]

Fixed in #285 (columnstore icon routing) and #288 (Parallelism subtype icons). Thanks again @rferraton for the icon contributions.