Skip to content

Fix vpk upload token#117

Merged
erikdarlingdata merged 1 commit intodevfrom
fix/vpk-upload-token
Mar 19, 2026
Merged

Fix vpk upload token#117
erikdarlingdata merged 1 commit intodevfrom
fix/vpk-upload-token

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

@erikdarlingdata erikdarlingdata commented Mar 19, 2026

vpk needs --token explicitly, doesn't read GH_TOKEN.

Summary by CodeRabbit

  • Chores
    • Enhanced release pipeline security by implementing authenticated access for artifact management operations during the release process.

vpk upload doesn't read GH_TOKEN env var — needs --token parameter.
Also pass token to vpk download for rate limiting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit a315155 into dev Mar 19, 2026
1 check passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c52f56e3-924b-438e-badb-1f9ab2c9271b

📥 Commits

Reviewing files that changed from the base of the PR and between 8bc4365 and 54838c3.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The GitHub Actions release workflow is updated to authenticate vpk commands using a GitHub token environment variable. Authentication tokens are added to both the prior-release download and artifact upload steps, replacing unauthenticated invocations.

Changes

Cohort / File(s) Summary
Workflow Authentication
.github/workflows/release.yml
Added --token $env:GH_TOKEN parameter to both vpk download github and vpk upload github commands for authenticated API access.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vpk-upload-token
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@erikdarlingdata erikdarlingdata mentioned this pull request Mar 19, 2026
@erikdarlingdata erikdarlingdata deleted the fix/vpk-upload-token branch April 9, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant