Fix search filter not applied and slicer reset on Fetch (#147)#150
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 27, 2026
Merged
Fix search filter not applied and slicer reset on Fetch (#147)#150erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
Two regressions introduced in the time slicer PR (#114): 1. Search filter (module, query_id, etc.) was built via BuildSearchFilter() but never passed to FetchTopPlansAsync — the filter parameter was dropped when the call site switched to named parameters for startUtc/ endUtc. Add filter: back to the call. 2. Clicking Fetch reloads the slicer via LoadTimeSlicerDataAsync, which calls LoadData without preserving the current selection. LoadData defaults to last 24h when no selection is provided, discarding the user's custom range. Pass the current _slicerStartUtc/_slicerEndUtc through to LoadData's selectionStart/selectionEnd parameters. Fixes #147 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@erikdarlingdata : the {filterSql} in FetchTopPlansAsync is (i think) apply too late in the query : it search inside the top x. if it is what you want, no need sql. To search inside the TOPplans dataset the app already have : a filtering that reduce the list should be fast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two regressions from the time slicer PR (#114), both in
FetchPlansForRangeAsync:Search filter dropped —
BuildSearchFilter()result was never passed toFetchTopPlansAsync. The call switched to named params forstartUtc/endUtcandfilter:was lost in the process.Slicer resets to 24h on Fetch —
Fetch_Clickreloads slicer data viaLoadTimeSlicerDataAsync, which callsLoadDatawithout the current selection.LoadDatadefaults to last 24h. Now passes_slicerStartUtc/_slicerEndUtcthrough to preserve the user's range.Fixes #147
Test plan
🤖 Generated with Claude Code