Fix false positive warnings and UI improvements (#178)#180
Merged
erikdarlingdata merged 4 commits intomainfrom Apr 7, 2026
Merged
Fix false positive warnings and UI improvements (#178)#180erikdarlingdata merged 4 commits intomainfrom
erikdarlingdata merged 4 commits intomainfrom
Conversation
- Rule 3 (Serial Plan): Skip trivial statements with cost < 0.01 — a 0ms variable assignment shouldn't warn about MAXDOP 1 - Rule 15 (Join OR Clause): Exclude Merge Interval patterns inside anti/semi joins — NOT IN subqueries produce the same operator chain but aren't OR expansions - Rule 26 (Row Goal): Require >= 2x reduction — "1 to 1 (1x reduction)" and tiny floating-point differences are noise Tests load from .internal/examples (gitignored) and skip gracefully on CI. Closes items 5, 9, 12 from #178. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rule 1 (Filter Operator): Suppress when child subtree is trivial — actual plans: < 128 reads AND < 10ms; estimated plans: cost < 1.0 - Rule 20 (Local Variables): Gate on statement cost >= 0.01 to skip trivial variable assignments where estimate quality doesn't matter Both fixes work correctly for estimated and actual plans, using cost-based fallbacks when runtime stats aren't available. Closes items 6, 7, 11 from #178. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rule 4/6 (Scalar UDF): Expanded remediation options — mention assigning to a variable, SQL Server 2019+ automatic UDF inlining - Warning badge: Split count by severity (critical/warning/info) with color-coded badges instead of a single combined number - Statement tabs: Show elapsed time instead of cost for actual plans - Wait stats: Wider wait type column (180px) and double-width card when populated for better readability Closes items 2, 3 (partial), 4, 10 from #178. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Statement tabs sorted by elapsed time (actual plans) or cost (estimated plans), slowest first — problem statement is always immediately visible - Replaced small PNG logo with full Darling Data barbell logo from erikdarling.com, bumped height to 40px for legibility - Default active statement is the first tab (sorted, so the slowest) Closes items 1, 3 from #178. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all 12 items from issue #178 community feedback:
False positive fixes (Rules):
Message improvements:
Web UI:
Test plan
🤖 Generated with Claude Code