Add maximum benefit scoring for plan analysis findings#219
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 13, 2026
Merged
Add maximum benefit scoring for plan analysis findings#219erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
Introduce BenefitScorer — a second-pass analysis that calculates the maximum percentage of elapsed time each finding could save if addressed. Findings are now sorted by benefit descending across CLI text/HTML output, JSON API, and the desktop app's Properties panel and tooltips. This reduces noise on large plans by surfacing high-impact findings first. Stage 1 of the maximum benefit system scores operator-level rules (Filter, Spill, Key Lookup, Scan, UDF, Nested Loops) using actual operator self-time, with CostPercent fallback for estimated plans. Bump version to 1.5.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BenefitScorer— a second-pass analysis that calculates the maximum % of elapsed time each finding could save if addressed ([FEATURE] Add system to assign a "maximum benefit" for plan analysis rules #215)Test plan
dotnet build— 0 errorsdotnet test— 75/75 passplanview analyzeoutput shows(up to N% benefit)tags🤖 Generated with Claude Code