Add wait stats benefit scoring (Stage 2)#224
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 14, 2026
Merged
Conversation
Calculate MaxBenefitPercent for each wait type in plan wait stats. Serial plans use a simple ratio (waitMs/elapsedMs). Parallel plans use Joe's proportional allocation formula, mapping wait types to relevant operators (I/O waits to operators with physical reads, CPU waits to operators with CPU work, etc.). Parallelism waits (CXPACKET/CXCONSUMER/CXSYNC) use the efficiency gap formula instead of raw wait time — threads waiting for other threads is a symptom, not directly addressable time. Benefits shown in CLI text, HTML export, JSON API (wait_benefits array), and desktop app wait stats ribbon. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitMs / elapsedMs * 100WaitBenefitmodel,wait_benefitsarray in JSON outputTest plan
dotnet build— 0 errorsdotnet test— 75/75 pass🤖 Generated with Claude Code