Fix false positives from Joe's plan review feedback#229
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 16, 2026
Merged
Conversation
- a7: Suppress Row Estimate Mismatch (Rule 5) for Lookup operators — key lookups are point lookups where per-execution estimate math is misleading - a8/a9: Suppress Non-SARGable (Rule 12), Scan With Predicate (Rule 11), and Implicit Conversion upgrade (Rule 29) on 0-execution nodes - a10: Suppress Row Goal (Rule 26) when actual rows confirm the row goal prediction was correct (optimizer stopped reading early as planned) - a13: Use actual wait stats in Parallel Wait Bottleneck message instead of generic "Common causes include..." text Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses quick-win items from Joe's feedback on issue #215 using plan
20260415_1.sqlplan:GetWaitStatsAdvicenow always uses actual wait stats (top 3 with percentages) instead of falling through to generic "Common causes include..." textTest plan
🤖 Generated with Claude Code