C8 expensive-operator rule + C9 columnstore on wide bare scans (#215)#263
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 22, 2026
Merged
Conversation
…215) C9: Rule 34 (Bare Scan) previously only fired when the scan output was ≤3 columns, since rowstore nonclustered indexes get expensive with more columns. Joe's point: columnstore (CCI/NCCI) doesn't care about column count, so a wide bare scan with nothing to suggest is a missed recommendation. Rule 34 now also fires on wide outputs (>3 columns) with columnstore-focused advice. Narrow-output path keeps the NC-index advice as before. C8: new Rule 35 "Expensive Operator" — emits when an operator's self- time is ≥20% of statement elapsed AND no other warning has already fired on the node. Ensures large work doesn't disappear just because the tool has nothing specific to suggest (Joe's scan-with-nothing-to-say case). Benefit % = self-time share; severity Critical at ≥50%, Warning otherwise. Self-guarded against existing warnings so it never stacks on top of a spill/lookup/etc. Neither rule fires on Joe's private plan (every significant operator already has a warning) or on 20260415_1.sqlplan (parallel work split). That's the expected "no false positives" behavior. Version bump 1.7.5 -> 1.7.6. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
erikdarlingdata
deleted the
feature/c8-expensive-operator-c9-columnstore
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Version 1.7.5 → 1.7.6.
🤖 Generated with Claude Code