Seed wait stats config file (#215 part 1)#296
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 29, 2026
Merged
Conversation
Adds src/PlanViewer.Core/Resources/WaitStats.json as the single source of truth for wait stat handling, populated only with attributes 1-5 (name, isPreemptive, isExternal, isImplemented, isEnabled). Attributes 6-12 (calc model, applicable operators, descriptions, URLs, internal comment) are intentionally null pending domain-expert review. 52 entries: 46 currently implemented (matched explicitly or via prefix in BenefitScorer / PlanViewerControl / WaitStatsKnowledge), 6 common waits that today fall to the 'Other' bucket (THREADPOOL, BACKUPIO, BACKUPBUFFER, HADR_SYNC_COMMIT, DBMIRROR_DBM_EVENT, SQLTRACE_BUFFER_FLUSH). No code is wired to this file yet — that's part 2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #215 — adds the human-readable config file that will become the single source of truth for wait stat handling.
What's in the file
src/PlanViewer.Core/Resources/WaitStats.json— 52 wait stat entries, populated only with the first 5 attributes per Joe's instruction:Attributes 6-12 (showWaitCount, showAverageWaitTime, timeCalculationModel, applicableOperatorNames, description, helpfulUrls, internalComment) are intentionally
null, reserved for domain-expert population.How seeding was determined
BenefitScorer.ClassifyWaitType(),PlanViewerControl.GetWaitCategory(), andWaitStatsKnowledge.cs.PREEMPTIVE_.IsExternalWait()routes the wait through the CPU-based external formula (today: PREEMPTIVE_* and MEMORY_ALLOCATION*). Conservative.wait_categorylevel (Idle, User Wait), and none of these entries fall into those.Not in this PR
<EmbeddedResource>) added yet — file is a plain checked-in JSON so reviewers can read the diff cleanly.Test plan
🤖 Generated with Claude Code