Bump to 1.11.0 and fix workflows broken by version unification#340
Merged
Conversation
PR #315 moved <Version> from App.csproj into src/Directory.Build.props but left four workflows still parsing the old path — every one of them would have silently produced an empty VERSION on the next release: - release.yml: would tag as "v" and break Velopack pack/upload - check-version-bump.yml: empty == empty would block legit bumps - nightly.yml: nightly tag becomes "-nightly.YYYYMMDD" - deploy-web.yml: also tried to write <Version> back into Web csproj, which no longer has one — drop the obsolete sync step entirely (both csprojs now inherit from Directory.Build.props automatically) Version bumps for 1.11.0: - src/Directory.Build.props 1.10.0 -> 1.11.0 - PlanViewer.Ssms/Properties/AssemblyInfo.cs 1.10.0.0 -> 1.11.0.0 - PlanViewer.Ssms/source.extension.vsixmanifest 1.10.0 -> 1.11.0 Also ignore untracked local tools/ helper directory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.10.0→1.11.0(insrc/Directory.Build.propsplus the two legacy SSMS files).<Version>fromsrc/PlanViewer.App/PlanViewer.App.csproj, which no longer contains one.deploy-web.yml(both App and Web csprojs now inherit fromDirectory.Build.propsautomatically — no sync needed).tools/directory to.gitignore.Why the workflow fixes can't wait
Without them, the upcoming dev → main release PR would fail in several specific ways:
release.ymlv, then break Velopack pack/uploadcheck-version-bump.yml"" == ""→ block merge even with a legitimate bumpnightly.yml-nightly.YYYYMMDD(no base version)deploy-web.yml<Version>element into Web.csproj that doesn't existBootstrap note
check-version-bump.ymlon this PR will read1.11.0fromrelease/1.11.0and (empty) fromdev's currentDirectory.Build.props. Those differ, so the check passes cleanly — no chicken-and-egg.Test plan
ci.ymlbuilds + tests pass on .NET 10)dev → mainPRcheck-version-bumpon the dev → main PR sees1.11.0(dev) vs1.10.0(main) and passesrelease.ymlon dev → main PR merge createsv1.11.0GitHub release with all platform zips + Velopack artifactsSIGNPATH_API_TOKENis unset)1.11.0as the base version🤖 Generated with Claude Code