Adopt validated colorblind-safe palette for Query Store visualizations#382
Merged
Conversation
- Replace database (DefaultTopDbColors) and plan-hash (PlanColors) categorical palettes with the 8-hue dataviz dark ramp in fixed CVD order; both QS views now share one validated palette (previously two palettes that each failed CVD/contrast checks). - Migrate installs still on the old defaults to the new ramp; leave any user-customized colors untouched. - Donut percentage labels pick ink by arc luminance so they stay readable on light fills (mirrors the bar-card rule). - Add a 1px surface gap between stacked wait-stat segments so bands stay distinct. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Applies the
/datavizskill's validated colorblind-safe categorical ramp to the two Query Store visualizations, replacing two ad-hoc palettes that each failed the validator's CVD/contrast checks.Changes
DefaultTopDbColors(Multi QS Overview databases, 10 slots -> 8) andPlanColors(query-history scatter, 8 -> 8) now use the same 8-hue dataviz dark ramp in fixed CVD-safe slot order. Databases beyond the 8th fold into the neutral "Others" fill (dataviz rule: never invent a 9th hue).Validation
datavizpalette validator against the app's dark surfaces (#22252D,#1A1D23): the old palettes FAIL (plan-hash#A1887Fread as gray and collided with pink under deutan; both failed the lightness band). The new ramp PASSES all checks (lightness, chroma, contrast; CVD sits in the legal 8-12 floor band, backed by the direct labels / legend both charts already carry).Notes
#1A5276) left as-is: it is low-contrast on the dark surface, but changing it is a product-semantics decision, not a palette-safety one.🤖 Generated with Claude Code