Fix database picker not changing query editor context (#92)#95
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 17, 2026
Merged
Fix database picker not changing query editor context (#92)#95erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
Rebuild connection string from current database selection at execution time rather than relying on cached _connectionString from SelectionChanged. Guarantees the picker state is always reflected when running queries. Closes #92 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_serverConnection+_selectedDatabaseat query execution time_connectionStringcould be stale after changing the database pickerTest plan
SELECT DB_NAME(), change database picker, run again — returns new database nameCloses #92
🤖 Generated with Claude Code