Merged
Conversation
erikraft
temporarily deployed
to
l10n_master3 - ErikrafT Drop - Backend PR #182
Render
Destroyed
WalkthroughThis PR populates empty LAN mode localization strings across 42+ language files, replacing empty placeholders with concrete UI labels, help text, server configuration examples, and status messages. The same set of LAN-related translation keys are updated consistently across all locale files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
bot
added
the
codex
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Fix all issues with AI agents
In `@public/lang/ca-ES.json`:
- Line 14: The Catalan locale file contains English strings that must be
localized or cleared to fall back; update the keys (e.g., "lan-mode_title", and
the other keys referenced around lines 56, 66-73, 154, and 205-209) by replacing
the English text with proper Catalan translations or set the values to an empty
string if your Crowdin/translation policy requires leaving untranslated entries
blank, and confirm with the localization policy/team before committing.
In `@public/lang/eu-ES.json`:
- Line 14: The eu-ES locale file contains an English value for the key
"lan-mode_title" — replace the current value "LAN Mode" with the correct Basque
translation for that key and push the update through Crowdin for proper
localization; locate the "lan-mode_title" entry in public/lang/eu-ES.json and
update its value to the approved Basque string.
In `@public/lang/pl-PL.json`:
- Line 14: The Polish locale file contains an English value for the
"lan-mode_title" key; update the value for "lan-mode_title" in pl-PL.json to a
proper Polish translation (e.g., "Tryb LAN" or the Crowdin-provided translation)
so the string is localized for Polish users.
In `@public/lang/pt-BR.json`:
- Line 14: The JSON entry "lan-mode_title" is still in English; update its value
to Portuguese (pt-BR) — e.g., change "LAN Mode" to "Modo LAN" — by editing the
"lan-mode_title" key in public/lang/pt-BR.json and preserving valid JSON syntax
(quotes/commas) and formatting.
In `@public/lang/zh-CN.json`:
- Line 14: The zh-CN localization file currently contains English values for the
new LAN-related keys (e.g., "lan-mode_title" and the other new entries
introduced around the referenced ranges); replace those English strings with
proper Simplified Chinese translations for each key (or, if intentional, add an
explicit fallback comment/value indicating English is intended), ensuring the
keys such as "lan-mode_title" and the other LAN strings at the noted locations
are updated so the file remains fully localized and consistent.
In `@public/lang/zh-TW.json`:
- Line 14: The file contains new LAN-related keys left in English (e.g.,
"lan-mode_title") inside the zh-TW locale; translate each new key's value into
Traditional Chinese (zh-TW) or explicitly mark them to fall back to English if
that is the intended strategy. Locate all new LAN entries (including the key
"lan-mode_title" and the other new entries referenced around the diff ranges)
and replace their English strings with proper zh-TW translations, ensuring you
keep the exact JSON keys unchanged and maintain valid JSON formatting (quotes,
commas). If you intentionally want English fallback instead of translations, add
a short comment in your PR description stating that fallback policy and leave
the values as-is. Ensure consistency across the keys so the UI does not display
mixed languages.
| "edit-paired-devices_title": "Edit paired devices", | ||
| "join-public-room_title": "Join public room temporarily", | ||
| "lan-mode_title": "", | ||
| "lan-mode_title": "LAN Mode", |
There was a problem hiding this comment.
Catalan locale still contains English strings.
These additions are English text in ca-ES. If the policy is to provide localized strings, these should be Catalan (or left empty to fall back). Please confirm with Crowdin/translation policy and update accordingly.
Also applies to: 56-56, 66-73, 154-154, 205-209
🤖 Prompt for AI Agents
In `@public/lang/ca-ES.json` at line 14, The Catalan locale file contains English
strings that must be localized or cleared to fall back; update the keys (e.g.,
"lan-mode_title", and the other keys referenced around lines 56, 66-73, 154, and
205-209) by replacing the English text with proper Catalan translations or set
the values to an empty string if your Crowdin/translation policy requires
leaving untranslated entries blank, and confirm with the localization
policy/team before committing.
| "edit-paired-devices_title": "Edit paired devices", | ||
| "join-public-room_title": "Join public room temporarily", | ||
| "lan-mode_title": "", | ||
| "lan-mode_title": "LAN Mode", |
There was a problem hiding this comment.
Localize the eu-ES string instead of English.
At Line 14 the value is still English in eu-ES.json. Please provide the proper Basque (or intended locale) translation via Crowdin for this locale.
🤖 Prompt for AI Agents
In `@public/lang/eu-ES.json` at line 14, The eu-ES locale file contains an English
value for the key "lan-mode_title" — replace the current value "LAN Mode" with
the correct Basque translation for that key and push the update through Crowdin
for proper localization; locate the "lan-mode_title" entry in
public/lang/eu-ES.json and update its value to the approved Basque string.
| "edit-paired-devices_title": "Edit paired devices", | ||
| "join-public-room_title": "Join public room temporarily", | ||
| "lan-mode_title": "", | ||
| "lan-mode_title": "LAN Mode", |
There was a problem hiding this comment.
Localize the Polish string instead of English.
At Line 14 the value is still English in pl-PL.json. Please provide a Polish translation (or pull the Crowdin translation) for this locale.
🤖 Prompt for AI Agents
In `@public/lang/pl-PL.json` at line 14, The Polish locale file contains an
English value for the "lan-mode_title" key; update the value for
"lan-mode_title" in pl-PL.json to a proper Polish translation (e.g., "Tryb LAN"
or the Crowdin-provided translation) so the string is localized for Polish
users.
| "edit-paired-devices_title": "Editar dispositivos emparelhados", | ||
| "join-public-room_title": "Entrar em uma sala pública temporariamente", | ||
| "lan-mode_title": "Modo LAN", | ||
| "lan-mode_title": "LAN Mode", |
There was a problem hiding this comment.
Translate LAN strings to Portuguese for pt-BR.
The locale is otherwise Portuguese, but this label is English. Please localize to keep UX consistent.
🤖 Prompt for AI Agents
In `@public/lang/pt-BR.json` at line 14, The JSON entry "lan-mode_title" is still
in English; update its value to Portuguese (pt-BR) — e.g., change "LAN Mode" to
"Modo LAN" — by editing the "lan-mode_title" key in public/lang/pt-BR.json and
preserving valid JSON syntax (quotes/commas) and formatting.
| "edit-paired-devices_title": "管理已配对设备", | ||
| "join-public-room_title": "暂时加入公共房间", | ||
| "lan-mode_title": "", | ||
| "lan-mode_title": "LAN Mode", |
There was a problem hiding this comment.
Localize the new LAN strings for zh-CN.
These new entries are still English in an otherwise localized file, which will surface mixed-language UI. Please translate or confirm the intended fallback strategy.
Also applies to: 56-56, 66-74, 154-154, 205-209
🤖 Prompt for AI Agents
In `@public/lang/zh-CN.json` at line 14, The zh-CN localization file currently
contains English values for the new LAN-related keys (e.g., "lan-mode_title" and
the other new entries introduced around the referenced ranges); replace those
English strings with proper Simplified Chinese translations for each key (or, if
intentional, add an explicit fallback comment/value indicating English is
intended), ensuring the keys such as "lan-mode_title" and the other LAN strings
at the noted locations are updated so the file remains fully localized and
consistent.
| "edit-paired-devices_title": "編輯已配對的裝置", | ||
| "join-public-room_title": "暫時加入公共房間", | ||
| "lan-mode_title": "", | ||
| "lan-mode_title": "LAN Mode", |
There was a problem hiding this comment.
Localize the new LAN strings for zh-TW.
These new entries are still English in an otherwise localized file, which will surface mixed-language UI. Please translate or confirm the intended fallback strategy.
Also applies to: 56-56, 66-74, 154-154, 205-209
🤖 Prompt for AI Agents
In `@public/lang/zh-TW.json` at line 14, The file contains new LAN-related keys
left in English (e.g., "lan-mode_title") inside the zh-TW locale; translate each
new key's value into Traditional Chinese (zh-TW) or explicitly mark them to fall
back to English if that is the intended strategy. Locate all new LAN entries
(including the key "lan-mode_title" and the other new entries referenced around
the diff ranges) and replace their English strings with proper zh-TW
translations, ensuring you keep the exact JSON keys unchanged and maintain valid
JSON formatting (quotes, commas). If you intentionally want English fallback
instead of translations, add a short comment in your PR description stating that
fallback policy and leave the values as-is. Ensure consistency across the keys
so the UI does not display mixed languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes