Sync upstream SponsorBlock 6.1.2 and DeArrow 2.2.3#23
Merged
Conversation
Port changes from ajayyy/SponsorBlock (6.1.0 -> 6.1.2+master) and ajayyy/DeArrow (2.1.11 -> 2.2.3+master): - Update maze-utils submodule to c1e0d65 (v3 extension support, brandingBoxSelector moved to thumbnail-selectors) - Port blob -> blobUrl migration for thumbnail handling (performance) - Add v3 extension support checks across thumbnailRenderer, titleRenderer, titleBar, videoBranding, and cssInjector - Add anti-translate compatibility detection in titleRenderer - Update embed selectors to array format in videoBranding - Move brandingBoxSelector import to maze-utils/src/thumbnail-selectors - Add yt-thumbnail-view-model CSS handling in cssInjector - Port chapter text rendering fix from SponsorBlock previewBar - Add ELO field to titleFormatterData - Add configurationName min-width CSS to options - Update webpack 5.94.0 -> 5.105.0 - Fix pre-existing DataCache constructor arg order in segmentData Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Contributor
Author
Original prompt from Erkin |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
Ports changes from ajayyy/SponsorBlock (6.1.0 → 6.1.2+master) and ajayyy/DeArrow (2.1.11 → 2.2.3+master).
Changes
Submodule & dependency updates:
isOnV3Extension(), movesbrandingBoxSelectortothumbnail-selectors, changesDataCacheconstructor signature)Blob → blobUrl migration (performance optimization):
thumbnailDataCache.ts: StoresblobUrl: stringinstead ofblob: Blob; addscleanup()callingURL.revokeObjectURL()thumbnailRenderer.ts,ThumbnailComponent.tsx,dataFetching.ts: Updated to useURL.createObjectURL()wrappingV3 extension support:
isOnV3Extension()checks acrossthumbnailRenderer.ts,titleRenderer.ts,titleBar.ts,videoBranding.tsOther upstream changes:
titleRenderer.ts: Anti-translate extension compatibility detectionvideoBranding.ts:embedSelector→embedSelectorsarray; added mobile selectorcssInjector.ts: Special handling foryt-thumbnail-view-modelblurred imagespreviewBar.ts: Chapter text rendering fixtitleFormatterData.ts: Added ELO fieldoptions.css: Added#configurationNamemin-widthBug fix (pre-existing):
segmentData.ts: FixedDataCacheconstructor arg order (5was being passed asonDeletecallback instead ofcacheLimit)Human Review Checklist
new Response(rendered.blobUrl).blob()pattern is correct for converting blobUrl back to blobConfig.config!.ignoreTranslatedTitles = trueas a side effect - verify this is intendedShowCustomBrandingInfotype hasactualValue?optional on boolean branch (differs from upstream but needed for existing code)5was silently ignored as invalid callbackLink to Devin run: https://app.devin.ai/sessions/f362a62259b143728a6a90d3184bbd2d
Requested by: @erkinalp