Fix of pull req #7
Conversation
- To make `-` before attrs highlighted
set syntax-propertize function - `$` in atom and string - Tripled-quoted string in doc or Var make erlang-ts-mode-syntax-table and mark `?$` as word - for char like `$'`, `$"`, `$\"`, modify text property as word
Let the user choose if they want different colors for module, function.
And update instructions, because an updated treesitter grammer is required.
|
Looks good to me. (might be a good idea to also add some trivial GHA that runs the built-in byte-compilation linting so such problems are immediately spotted) |
Yes, agree, need more time, this is done because I procrastinate other things :-) I did look at the testing you suggested but it was not trivial for me, emacs newbie every time I start doing something in lisp. |
|
Sorry forgot to reply to the PR... 🙃 |
| function-call | ||
| constant) | ||
| (operator ;; Level 4 | ||
| remote-module |
There was a problem hiding this comment.
The remote-module feature is a common function call in Erlang code.
I tend to enable it by default as a level 3 feature.
(The default level is 3, line 416)
There was a problem hiding this comment.
Some old timers don't like too much colors in their code.
Which is why I split up your code in function calls and remote-module calls, and
added function calls to level 3, and added remote to level 4.
Then the user can choose, and it is a menu click a way, I thought it was a good compromise,
you and I can set level 4.
There was a problem hiding this comment.
Agreed. I think overdoing the fontification by default is not a good idea as too much colors can make the code harder to read instead of easier. As that's easily configurable it's not a big deal.
|
@JimMoen what do you use to get the bracket high-lightning, |
|
@dgud |
4 participants
Clean up of pull request #2
Removed commits that where obsolete by later commits.
Squashed commits that changed the same functionality.
Added a commit with new operators and one which changes
the original face of remote module calls. Which all users don't want.
Replaces #2