Skip to content

Scan SKIP files in addition to scanning SKIP-APPLICATIONS#10537

Merged
kvakvs merged 1 commit intoerlang:maintfrom
kvakvs:eimytdl/1251-with-missing-libodbc/OTP-19914
Jan 21, 2026
Merged

Scan SKIP files in addition to scanning SKIP-APPLICATIONS#10537
kvakvs merged 1 commit intoerlang:maintfrom
kvakvs:eimytdl/1251-with-missing-libodbc/OTP-19914

Conversation

@kvakvs
Copy link
Contributor

@kvakvs kvakvs commented Jan 13, 2026

Problem

The documentation build step make docs displays a warning when an application has failed its configure step and was not built

Solution

Additional fix for documentation build warnings.
Covered case previously:

  • Application was skipped with user CLI option --without-XX

Covers a new case:

  • The application failed its configure step (for example a hard dependency is not found).

Additionally: new target added to the root Makefile to reset the generated documentation state: make clean_docs

Result

  • The generated documentation still has the application name in the left bar
  • The generated documentation correctly shows the placeholder when clicking the skipped application.

@kvakvs kvakvs requested a review from IngelaAndin January 13, 2026 10:37
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

CT Test Results

  1 files   11 suites   3m 1s ⏱️
 95 tests  91 ✅ 4 💤 0 ❌
111 runs  107 ✅ 4 💤 0 ❌

Results for commit b0d8a9e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kvakvs kvakvs self-assigned this Jan 13, 2026
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Jan 19, 2026
@IngelaAndin IngelaAndin requested review from sverker and removed request for IngelaAndin January 19, 2026 14:15
@kvakvs kvakvs added the testing currently being tested, tag is used by OTP internal CI label Jan 20, 2026
Update Makefile.in with the new 'clean_docs' target
@kvakvs kvakvs force-pushed the eimytdl/1251-with-missing-libodbc/OTP-19914 branch from 8301331 to b0d8a9e Compare January 20, 2026 13:19
@kvakvs kvakvs merged commit 7eb860e into erlang:maint Jan 21, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants