erts: Fix tty_tinfo_make_map function arguments#10895
Merged
frazze-jobb merged 1 commit intoerlang:masterfrom Apr 2, 2026
Merged
erts: Fix tty_tinfo_make_map function arguments#10895frazze-jobb merged 1 commit intoerlang:masterfrom
frazze-jobb merged 1 commit intoerlang:masterfrom
Conversation
Contributor
CT Test Results 3 files 136 suites 50m 5s ⏱️ Results for commit e1db22c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
previously approved these changes
Mar 23, 2026
According to [1], term_variables: bool*, num*, std* are `NCURSES_CONST char * const`. Where NCURSES_CONST is defined by ncurses configuration scripts [2]. 1: https://man7.org/linux/man-pages/man3/term_variables.3x.html 2: https://github.com/mirror/ncurses/blob/master/configure.in#L1228
8e78700 to
e1db22c
Compare
Contributor
Author
|
Hi, Builds for iOS and Windows are failing. I'll try to fix it. |
garazdawi
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to [1], term_variables: bool*, num*, std* are
NCURSES_CONST char * const. Where NCURSES_CONST is defined by ncurses configuration scripts [2].1: https://man7.org/linux/man-pages/man3/term_variables.3x.html
2: https://github.com/mirror/ncurses/blob/master/configure.in#L1228
Without this fix gcc 15.2 is saying: