Merged
Conversation
Contributor
CT Test Results 3 files 136 suites 49m 55s ⏱️ Results for commit d1eafda. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Contributor
|
Could be good to document the configure option and its incompatibility here |
Alternative implementation uses std::to_chars() in C++17 STL. Configure defaults to ryu as currently the float string format sometimes differ from ryu. Example: ryu "1.0e4" alt "10000.0" The reason in this case is that std:to_chars() returns "10000" and then we add ".0" and that makes it longer than "1.0e4". ToDo: It should be possible to mimic ryu and always choose the shortest by doing string conversions to/from the scientific formats. STL e-format: 1e+05 (no redundant '.', always exp sign, min exp 2 chars) ryu e-format: 1.0e5 (always '.', no exp '+', no exp min size)
sverker
force-pushed
the
sverker/erts/ryu-alternative
branch
from
7046a36 to
d1eafda
Compare
rickard-green
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The implementation of
float_to_list/binary(_, [short]).Why?
To optionally avoid yet another embedded 3PP.
Limitations