public_key: Validate OCSP responder certificate validity period#11136
Merged
Conversation
The OCSP responder certificate's notBefore/notAfter fields were not checked, allowing expired or not-yet-valid certificates to be accepted as valid OCSP responders. Add validity period verification before evaluating responder authorization (RFC 5280 Section 4.1.2.5, RFC 6960 Section 4.2.2.2).
Contributor
CT Test Results 2 files 18 suites 5m 47s ⏱️ For more details on these failures, see this check. Results for commit f735fd9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
f735fd9 to
b3870e0
Compare
IngelaAndin
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public_key: Validate OCSP responder certificate validity period
The OCSP responder certificate's notBefore/notAfter fields were not
checked, allowing expired or not-yet-valid certificates to be accepted
as valid OCSP responders.
Add validity period verification before evaluating responder
authorization (RFC 5280 Section 4.1.2.5, RFC 6960 Section 4.2.2.2).