Run ARM-specific tests consistently#434
Merged
paulo-ferraz-oliveira merged 3 commits intomainfrom Mar 14, 2026
Merged
Conversation
| const previousRunnerArch = process.env.RUNNER_ARCH | ||
|
|
||
| if (process.platform === 'linux') { | ||
| process.env.RUNNER_ARCH = 'X64' |
Collaborator
Author
There was a problem hiding this comment.
We wanna get rid of this type of manipulation.
Collaborator
Author
|
Ubuntu ARM: https://github.com/erlef/setup-beam/actions/runs/23092677042/job/67079875121?pr=434#step:1:15 Some of the above might fail, but the links are to show we're actually using ARM. Subsequent fixes should be simple as to not move away from the assumption. |
https://builds.hex.pm/builds/otp/arm64/ubuntu-<x>.04/builds.txt file is only available when <x> >= 20.
https://builds.hex.pm/builds/otp/arm64/ubuntu-20.04/builds.txt does not contain Erlang 19 any more...
paulo-ferraz-oliveira
force-pushed
the
fix/test-on-arm
branch
from
77fa577 to
83639f8
Compare
Collaborator
Author
|
Merging. It's "just" tests, but it supports our README 😄. |
Collaborator
Author
|
This was published in v1.23.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I adapt the tests to validate README assumptions: we run on latest ARM/AMD, where available.
Closes #289.