Open
Conversation
Collaborator
|
I believe we don’t have OTP builds for this target so I wouldn’t bother. I understand this PR is fixing tests but we shouldn’t be testing this in the first place in my opinion. Windows arm64 can run x64 builds but they segfault. Or worse yet they do not but otherwise provide weird results. I believe this is caused by JIT because builds with it disabled have been ok in my tests. |
Member
Author
|
Oh yes, you're right. Should I just disable that test in that case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add win11-arm64 to ImageOS mapping