Only print lines for os var that are set#586
Merged
lrascao merged 1 commit intoerlware:masterfrom Oct 19, 2017
Merged
Conversation
Contributor
Author
Contributor
Author
|
Just downloaded the latest version of relx, and just figured this wasnt merged. @tsloughter @lrascao Just wanted to let you know that completing this review will close 3 PRs, others linked above. Doesnt have to be this one, as they all achieve the same thing. ✌️ |
Collaborator
|
@expelledboy could you rebase onto master so we can get this merged? |
expelledboy
force-pushed
the
feature/replace-defined-os-vars
branch
from
ba96b57 to
57cce73
Compare
Contributor
Author
|
@lrascao done |
This was referenced Oct 19, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would prefer just using bash echo eval trick, which would allow specifying default etc, but this atleast allows setting the default in application env and optionally configuring if ENV var are set.