Fixing windows paths for bin scripts#597
Merged
lrascao merged 1 commit intoerlware:masterfrom Jul 5, 2017
Merged
Conversation
The syntax for proper path handling when the path may contain
parentheses (such as C:\Program Files (x86)\...) requires quoting the
entire assignment expression:
set "var=%val%"
any other way of doing it may interpret the parentheses and cause
failures.
Collaborator
|
thanks, sadly windows doesn't get a lot of love |
Collaborator
Author
|
yeah there are still some oddities around the service installation bit, but I ran out of time. I'll try to revisit again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The syntax for proper path handling when the path may contain
parentheses (such as C:\Program Files (x86)...) requires quoting the
entire assignment expression:
any other way of doing it may interpret the parentheses and cause
failures.
This currently prevents any windows release on x86 from running altogether.