Skip to content

OTP-20 unicode support and OTP-21 readiness#618

Merged
lrascao merged 4 commits intoerlware:masterfrom
ferd:otp-20-unicode-support
Nov 11, 2017
Merged

OTP-20 unicode support and OTP-21 readiness#618
lrascao merged 4 commits intoerlware:masterfrom
ferd:otp-20-unicode-support

Conversation

@ferd
Copy link
Copy Markdown
Collaborator

@ferd ferd commented Nov 1, 2017

This PR contains two commits:

  1. conditionally switch (on a version flag) to unicode-aware string functions and prevent compile warnings
  2. the no_dot_erlang.boot file appears to have been made default in a few places and relx would not copy the file around, causing issues in using nodetool with OTP-21. The patch addresses this.

ferd added 2 commits November 1, 2017 15:40
Use either optional compilation or version-safe variants of the string
functions. Prevents warnings when the switch to OTP-21 will happen.
Had a problem in OTP-21 (master) where escript calls in nodetool would
fail since the file is not around and is being used by default there.

The patch works by copying its equivalent file, which I belive to be
just the start_clean file (their .rel.src are identical), into the same
directories as we do for start_clean.

Internal errors are renamed to be made neutral.
@ferd ferd mentioned this pull request Nov 2, 2017
@ferd ferd changed the title [WIP] OTP-20 unicode support and OTP-21 readiness OTP-20 unicode support and OTP-21 readiness Nov 3, 2017
@ferd
Copy link
Copy Markdown
Collaborator Author

ferd commented Nov 3, 2017

I've updated this branch with the now-updated packages and it is ready for consideration.

@lrascao
Copy link
Copy Markdown
Collaborator

lrascao commented Nov 11, 2017

👍

@lrascao lrascao merged commit 1d05166 into erlware:master Nov 11, 2017
@ferd
Copy link
Copy Markdown
Collaborator Author

ferd commented Nov 12, 2017

Any chance to get this on hex soon-ish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants