Add View::Copy and Frame::Copy returning by value#349
Merged
ermig1979 merged 2 commits intoMay 20, 2026
Conversation
Add new Copy() overloads (no args and with Rectangle) returning a new View/Frame by value, alongside the existing pointer-returning Clone().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Copy()overloads toViewandFramethat return a new object by value, alongside the existingClone()methods which return raw pointers the caller mustdelete.Details
View::Clone()andFrame::Clone()returnView*/Frame*, leaving ownership to the caller. This patch adds value-returning counterparts:View<A> View<A>::Copy() constView<A> View<A>::Copy(const Rectangle<ptrdiff_t>& rect) constFrame<A> Frame<A>::Copy() constFrame<A> Frame<A>::Copy(const Rectangle<ptrdiff_t>& rect) constImplementation mirrors the existing
Clone():View::Copy()does row-wisememcpyinto a freshly constructedView;Frame::Copy()constructs a newFrameand delegates to the globalSimd::Copy(src, dst). The region overloads forward toRegion(rect).Copy().No changes to existing API.