chore: pre-release cleanup and workflow optimization for v1.12.0#53
Merged
chore: pre-release cleanup and workflow optimization for v1.12.0#53
Conversation
This commit prepares the repository for the v1.12.0 release by cleaning up misplaced files, adding GitHub Copilot support, and fixing CI workflow issues. Changes: - Remove duplicate benchmark files from root directory (already in benchmarks/) - Remove temporary benchmark files (benchmark-baseline.txt, benchmark-20251128-171330.txt) - Add .github/copilot-instructions.md for GitHub Copilot integration - Remove .github/workflows/claude-code-review.yml (replaced by native Copilot PR reviews) - Enable Go module caching in all GitHub Actions workflows (go-race.yml, go.yml, golangci-lint.yml) The race-test workflow was failing with exit code 143 (timeout) because Go modules were being downloaded fresh on every run. Enabling cache: true in actions/setup-go@v6 resolves this by caching both downloaded modules and build artifacts, reducing CI time and preventing timeouts. All benchmark files from v1.9.10 forward are now properly organized in the benchmarks/ directory (backfilled in PR #48). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the repository for v1.12.0 release by cleaning up misplaced benchmark files, adding GitHub Copilot integration, removing an obsolete workflow, and optimizing CI performance through caching.
- Removes duplicate benchmark files from root directory that already exist in benchmarks/
- Removes temporary benchmark files that should be gitignored
- Adds .github/copilot-instructions.md to provide GitHub Copilot with project context
- Removes claude-code-review.yml workflow (replaced by native GitHub Copilot)
- Enables Go module and build caching in CI workflows to improve performance
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| benchmark-v1.9.12.txt | Removed duplicate from root (proper copy exists in benchmarks/) |
| benchmark-v1.9.10.txt | Removed duplicate from root (proper copy exists in benchmarks/) |
| benchmark-comparison-v1.9.12.txt | Removed comparison file (should be gitignored, not committed) |
| .github/copilot-instructions.md | Added GitHub Copilot guidance based on CLAUDE.md |
| .github/workflows/claude-code-review.yml | Removed workflow replaced by native GitHub Copilot |
| .github/workflows/golangci-lint.yml | Added cache: true to speed up CI |
| .github/workflows/go.yml | Added cache: true to speed up CI |
| .github/workflows/go-race.yml | Added cache: true to fix timeout issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 42 42
Lines 7795 7795
=======================================
Hits 5186 5186
Misses 2070 2070
Partials 539 539 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prepares the repository for the v1.12.0 release by cleaning up misplaced files, adding GitHub Copilot support, and fixing the failing race-test workflow.
Changes
1. Benchmark Files Cleanup
benchmark-comparison-v1.9.12.txt(duplicate ofbenchmarks/benchmark-comparison-v1.9.12.txt)benchmark-v1.9.10.txt(duplicate ofbenchmarks/benchmark-v1.9.10.txt)benchmark-v1.9.12.txt(duplicate ofbenchmarks/benchmark-v1.9.12.txt)benchmark-baseline.txtbenchmark-20251128-171330.txtbenchmarks/directory2. GitHub Copilot Integration
.github/copilot-instructions.mdbased onCLAUDE.md3. Workflow Cleanup
.github/workflows/claude-code-review.yml(replaced by native GitHub Copilot PR reviews)4. CI Performance Optimization and Race-Test Fix
.github/workflows/go-race.yml.github/workflows/go.yml.github/workflows/golangci-lint.ymlcache: truetoactions/setup-go@v6in each workflowProblem Solved
The race-test workflow was consistently failing with exit code 143 (SIGTERM), indicating a timeout. Investigation revealed:
Root Cause: The workflow timeout (30 minutes) was being exceeded because:
Solution: Enabled Go module and build caching via
cache: trueinactions/setup-go@v6Expected Impact:
Local Verification: Ran race tests locally with
-race -timeout=20m -parallel=4flags - all tests passed in ~3 minutes with no race conditions detected.Testing
benchmarks/directorygo test -race -timeout=20m -parallel=4 ./...locally - all tests pass.github/copilot-instructions.mdcontains complete project guidanceRelated Issues
Part of v1.12.0 release preparation (includes builder package from PR #52)
🤖 Generated with Claude Code