ci: increase go test timeout from 5m to 10m in test command#55
Merged
Conversation
The previous fix (PR #54) increased the job-level timeout but the actual go test command still had -timeout=5m which was causing tests to timeout after ~47 seconds when hitting the 5-minute limit. This changes the -timeout flag in the go test command from 5m to 10m to match the job-level timeout and allow tests to complete.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 42 42
Lines 7795 7795
=======================================
Hits 5186 5186
Misses 2070 2070
Partials 539 539 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes test timeouts in the GitHub Actions CI workflow by increasing the go test timeout flag from 5 minutes to 10 minutes, aligning it with the job-level timeout that was previously increased in PR #54. The change ensures that tests have sufficient time to complete on first runs when downloading dependencies, while cached runs still complete quickly (~30 seconds).
Key Changes
- Updated
go test-timeoutflag from 5m to 10m in the main CI workflow - Ensures consistency between the test-level timeout and the job-level timeout (both now 10 minutes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the actual root cause of the Go workflow test timeouts.
Problem
PR #54 increased the job-level
timeout-minutesfrom 5 to 10, but the tests were still timing out after ~47 seconds. This is because thego testcommand itself has a-timeout=5mflag that takes precedence.Looking at line 33 of
.github/workflows/go.yml:The
-timeout=5mflag tells Go's test runner to kill tests after 5 minutes, regardless of the GitHub Actions job timeout.Solution
Change
-timeout=5mto-timeout=10min thego testcommand to match the job-level timeout.Why This Matters
Without this fix:
With this fix:
Testing
The tests themselves don't have any hangs - they just need more time on first runs when downloading dependencies. Local runs complete successfully in ~30 seconds with warm cache.