Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery

Summary:
Ref T4100. Ref T5595.

To support a unified "Projects:" query across all applications, a future diff is going to add a set of "Edge Logic" capabilities to `PolicyAwareQuery` which write the required SELECT, JOIN, WHERE, HAVING and GROUP clauses for you.

With the addition of "Edge Logic", we'll have three systems which may need to build components of query claues: ordering/paging, customfields/applicationsearch, and edge logic.

For most clauses, queries don't currently call into the parent explicitly to get default components. I want to move more query construction logic up the class tree so it can be shared.

For most methods, this isn't a problem, but many subclasses define a `buildWhereClause()`. Make all such definitions protected and consistent.

This causes no behavioral changes.

Test Plan: Ran `arc unit --everything`, which does a pretty through job of verifying this statically.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, hach-que, epriestley

Maniphest Tasks: T4100, T5595

Differential Revision: https://secure.phabricator.com/D12453

Author: epriestley

src/applications/almanac/query/AlmanacBindingQuery.php

@@ -93,7 +93,7 @@ protected function willFilterPage(array $bindings) {
     return $bindings;
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids !== null) {

src/applications/almanac/query/AlmanacDeviceQuery.php

@@ -49,7 +49,7 @@ protected function loadPage() {
     return $table->loadAllFromArray($data);
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids !== null) {

src/applications/almanac/query/AlmanacInterfaceQuery.php

@@ -83,7 +83,7 @@ protected function willFilterPage(array $interfaces) {
     return $interfaces;
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids !== null) {

src/applications/almanac/query/AlmanacNetworkQuery.php

@@ -31,7 +31,7 @@ protected function loadPage() {
     return $table->loadAllFromArray($data);
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids !== null) {

src/applications/almanac/query/AlmanacPropertyQuery.php

@@ -71,7 +71,7 @@ protected function willFilterPage(array $properties) {
     return $properties;
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids !== null) {

src/applications/almanac/query/AlmanacServiceQuery.php

@@ -88,7 +88,7 @@ protected function buildJoinClause($conn_r) {
     return implode(' ', $joins);
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids !== null) {

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

@@ -51,7 +51,7 @@ protected function loadPage() {
     return $table->loadAllFromArray($data);
   }
 
-  protected function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->ids) {

src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php

@@ -33,7 +33,7 @@ protected function loadPage() {
     return $logs;
   }
 
-  private function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     $where[] = $this->buildPagingClause($conn_r);

src/applications/chatlog/query/PhabricatorChatLogQuery.php

@@ -55,7 +55,7 @@ protected function willFilterPage(array $events) {
     return $events;
   }
 
-  private function buildWhereClause($conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     $where[] = $this->buildPagingClause($conn_r);

src/applications/conduit/query/PhabricatorConduitLogQuery.php

@@ -25,7 +25,7 @@ protected function loadPage() {
     return $table->loadAllFromArray($data);;
   }
 
-  private function buildWhereClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
     if ($this->methods) {