Merged
Conversation
erweixin
approved these changes
Apr 12, 2026
| ratex-font = { workspace = true, optional = true } | ||
| ratex-layout = { workspace = true, optional = true } | ||
| ratex-parser = { workspace = true, optional = true } | ||
| rust-embed = { version = "8.11.0", features = ["debug-embed"], optional = true } |
Owner
There was a problem hiding this comment.
Maybe we could move the rust-embed = 8.11.0 pin to the root Cargo.toml to keep it consistent across the workspace, and use { workspace = true, optional = true } here, since ratex-render will depend on it.
| { | ||
| for (id, filename) in &font_map { | ||
| if let Some(font) = Fonts::get(filename) { | ||
| data.insert(*id, font.data.to_vec()); |
Owner
There was a problem hiding this comment.
Small nit: consider erroring if any embedded font is missing (or if data.len() != font_map.len()), so we don’t return Ok with an empty/partial set—happy to drop if you prefer a softer fallback.
Owner
|
Thanks very much for the PR — overall it looks great to me. I left two small suggestions. It would also be appreciated if you could update the docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38
Only
ratex-svgat the moment to wait for feedback about the PR first.