Skip to content

Panel.js refers to session variable 'minions-txt' #712

@erwindon

Description

@erwindon

Describe the bug
One location in Panel.js refers to session variable minions-txt
But everywhere else the reference is minions_txt:

saltgui/static/scripts/panels/Panel.js:        Utils.setStorageItem("session", "minions_txt", JSON.stringify(minions));
saltgui/static/scripts/panels/Panel.js:        Utils.setStorageItem("session", "minions_txt", "{}");
saltgui/static/scripts/panels/Panel.js:      Utils.setStorageItem("session", "minions_txt", "{}");
saltgui/static/scripts/panels/Panel.js:    const minionsDict = Utils.getStorageItemObject("session", "minions-txt");
saltgui/static/scripts/panels/Keys.js:    const minionsDict = Utils.getStorageItemObject("session", "minions_txt");
saltgui/static/scripts/panels/Keys.js:    const minionsDict = Utils.getStorageItemObject("session", "minions_txt");

To Reproduce
Look in the source code

Expected behaviour
The inconsistent naming is not expected.

Additional context
The effect of this inconsistency is not known yet.
It is just an observation of an inconsistency.

This code is only used in for offline minions.

This is used to differentiate between accidental/onpurpose offline situations.
It should be working like this:
Image
(tooltip explains that second one is offline on purpose)
but it is looking as:
Image

fixing the name to minions_txt fixes that.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions