Skip to content

feat: add codemods for number.* polyfills#57

Merged
thepassle merged 6 commits intoes-tooling:mainfrom
xeho91:number-polyfills
Jul 22, 2024
Merged

feat: add codemods for number.* polyfills#57
thepassle merged 6 commits intoes-tooling:mainfrom
xeho91:number-polyfills

Conversation

@xeho91
Copy link
Copy Markdown
Contributor

@xeho91 xeho91 commented Jul 22, 2024

Nothing much to do with those polyfills packages. Except removing the possible imports.

Luckily they're not popular (based on downloads).

@xeho91
Copy link
Copy Markdown
Contributor Author

xeho91 commented Jul 22, 2024

Related: e18e/module-replacements#110

Comment thread test/fixtures/number.isfinite/case-1/before.js
Comment thread test/fixtures/number.isinteger/case-1/before.js
@thepassle
Copy link
Copy Markdown
Collaborator

Thanks for the PRs! Can you double check the before fixtures? I'm missing imports for the packages that should be removed. Thanks!

@xeho91
Copy link
Copy Markdown
Contributor Author

xeho91 commented Jul 22, 2024

Thanks for the PRs! Can you double check the before fixtures? I'm missing imports for the packages that should be removed. Thanks!

You're right, I fixed em.

Good to note: I am not sure if I got the imports right. Because to be honest, I struggle to understand the complexity of the polyfill system 🤷

I've just quickly looked at imports field on package.json in each of these packages, and what is there to import.

@thepassle
Copy link
Copy Markdown
Collaborator

Yeah I think this is fine for now, the es-shims polyfill api or whatever is pretty weird, we can improve on it in the future if it turns out to be a problem. The largest uses of these packages are fairly straightforward; import function, call function.

Thanks for the contribution!

@thepassle thepassle merged commit 8537550 into es-tooling:main Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants