Skip to content

docs: move inherits to preferred manifest#451

Merged
43081j merged 3 commits intoes-tooling:mainfrom
gameroman:update-inherits
Mar 17, 2026
Merged

docs: move inherits to preferred manifest#451
43081j merged 3 commits intoes-tooling:mainfrom
gameroman:update-inherits

Conversation

@gameroman
Copy link
Contributor

@gameroman gameroman commented Mar 16, 2026

Closes #147

@gameroman gameroman marked this pull request as ready for review March 16, 2026 19:51
"inherits": {
"id": "inherits",
"type": "removal",
"description": "You can just use the `class` syntax.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably just keep inherits since all other removals work this way (i.e. every removal and its mapping have the same id).

we just need to reword the description and set the URL. we should also mention Object.create

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly a 'removal', I think it should be either 'documented' or 'native'. 'removal' is more for things that can be removed without adding anything in return

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making it 'documented' would be better so we could better explain how to move from inherits to something else

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, its not a removal. it is native though - just there are two possibly syntaxes to replace it.

because of that, sure lets put it in preferred manifest for now as a documented replacement.

very simple example in the doc of extends and Object.create

all done then

@gameroman gameroman changed the title docs: update inherits description docs: move inherits to preferred manifest Mar 17, 2026
@gameroman gameroman requested a review from 43081j March 17, 2026 01:16
@43081j 43081j merged commit ba15bbd into es-tooling:main Mar 17, 2026
3 checks passed
@gameroman gameroman deleted the update-inherits branch March 17, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inherits replacement recommendation is not dev friendly

3 participants