docs: update fs-extra documentation#461
Merged
43081j merged 2 commits intoes-tooling:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
joaopedrodcf
left a comment
joaopedrodcf
left a comment
There was a problem hiding this comment.
Great improvements in the migration examples 🙏
joaopedrodcf
approved these changes
Mar 17, 2026
43081j
reviewed
Mar 19, 2026
docs/modules/fs-extra.md
Outdated
| ```js | ||
| await fsExtra.mkdirs(dir) // [!code --] | ||
| await fsExtra.mkdirp(dir) // [!code --] | ||
| await fsExtra.ensureDir(dir) // [!code --] |
Contributor
There was a problem hiding this comment.
this doesn't actually work as a diff since you'd never have all 3 replaced by 1
it should either be all 3 again in the after, or just mention that this is the same for mkdirs and ensureDir in a comment
43081j
reviewed
Mar 19, 2026
docs/modules/fs-extra.md
Outdated
| ```js | ||
| fsExtra.mkdirsSync(dir) // [!code --] | ||
| fsExtra.mkdirpSync(dir) // [!code --] | ||
| fsExtra.ensureDirSync(dir) // [!code --] |
Contributor
There was a problem hiding this comment.
same as above, this doesn't work as a diff. gave a suggestion in the other comment
43081j
reviewed
Mar 19, 2026
docs/modules/fs-extra.md
Outdated
|
|
||
| ```js | ||
| await fsExtra.ensureFile(file) // [!code --] | ||
| await fsExtra.createFile(file) // [!code --] |
Contributor
There was a problem hiding this comment.
this one too doesn't work as a diff. see other comment
edit: in fact all the ones below here have the same issue. so probably just fix all in one go
43081j
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #452