Skip to content

docs: setup firebase hosting con github actions #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esam-dev merged 1 commit into from
Mar 10, 2026
Merged

docs: setup firebase hosting con github actions #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .firebaserc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"projects": {
"default": "expense-tracker-eee50"
"default": "finanz-services"
}
}
20 changes: 20 additions & 0 deletions .github/workflows/firebase-hosting-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# This file was auto-generated by the Firebase CLI
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on merge
on:
push:
branches:
- main
jobs:
build_and_deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm ci && npm run build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: ${{ secrets.GITHUB_TOKEN }}
firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FINANZ_SERVICES }}
channelId: live
projectId: finanz-services
Comment on lines +14 to +20
Copy link

@qodo-code-review qodo-code-review bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Deploys placeholder site 🐞 Bug ✓ Correctness

The new workflows run npm run build but Firebase Hosting is configured to serve the checked-in
public/ directory, so the deployment can publish the default Firebase placeholder page instead of
the app. This will make production deploys incorrect even though CI reports a successful
build/deploy.
Agent Prompt 
## Issue description
GitHub Actions runs `npm run build`, but Firebase Hosting is configured to serve `public/`, which currently contains the default Firebase Hosting placeholder page. This means deployments can publish the placeholder instead of the built app.

## Issue Context
- `firebase.json` serves `public/` and rewrites all routes to `/index.html`.
- `public/index.html` is the Firebase Hosting welcome page.
- Build script is `vite build` and there is no Vite config shown to emit output into `public/`.

## Fix Focus Areas
- firebase.json[1-16]
- package.json[6-16]
- vite.config.ts[1-30]
- .github/workflows/firebase-hosting-merge.yml[13-20]
- .github/workflows/firebase-hosting-pull-request.yml[15-21]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

21 changes: 21 additions & 0 deletions .github/workflows/firebase-hosting-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# This file was auto-generated by the Firebase CLI
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on PR
on: pull_request
permissions:
checks: write
contents: read
pull-requests: write
jobs:
build_and_preview:
if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm ci && npm run build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: ${{ secrets.GITHUB_TOKEN }}
firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FINANZ_SERVICES }}
projectId: finanz-services