feat(workflow): add WorkflowRunnerService for event-driven workflow firing#19
Open
mpge wants to merge 1 commit intofeat/workflow-executorfrom
Open
feat(workflow): add WorkflowRunnerService for event-driven workflow firing#19mpge wants to merge 1 commit intofeat/workflow-executorfrom
mpge wants to merge 1 commit intofeat/workflow-executorfrom
Conversation
…iring
Ports the NestJS workflow-runner.service.ts to .NET. Loads active
Workflows for a trigger event (in Position order via EF Core),
evaluates conditions via WorkflowEngine, dispatches matches to
WorkflowExecutorService, and writes a WorkflowLog audit row per
Workflow considered.
- Honors StopOnMatch (only when the workflow actually matches)
- Catches executor failures so one bad workflow never blocks the rest
(failure stamped on the log row via ErrorMessage; logged via ILogger)
- Malformed conditions JSON logs a warning and treats the workflow as
non-matching
- Null/blank/{} conditions match all tickets (matches NestJS semantics)
Follow-up PR will add the event listener that bridges TicketCreatedEvent
/ TicketUpdatedEvent / etc. into RunForEventAsync.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the NestJS
workflow-runner.service.tsto .NET. Loads active Workflows for a trigger event (inPositionorder via EF Core), evaluates conditions viaWorkflowEngine, dispatches matches toWorkflowExecutorService, and writes aWorkflowLogaudit row per Workflow considered.Behavior
StopOnMatch— only when the workflow actually matchesErrorMessage; logged viaILogger){}conditions match all tickets (NestJS parity)Scope
Runner only. Follow-up PR: event listener that bridges
TicketCreatedEvent/TicketUpdatedEvent/ etc. intoRunForEventAsync.Dependencies
feat/workflow-executor). Will rebase ontomainonce feat(workflow): add WorkflowExecutorService for action dispatch #18 merges.Test plan
test,lint(won't trigger against stacked base until rebased)