feat(newsletters): admin UI for newsletter system (Wave 0)#75
Open
mpge wants to merge 14 commits into
Open
Conversation
Adds a Newsletters entry to the admin sidebar in EscalatedLayout, gated on the backend-injected `escalated.features.newsletters === true` shared prop. Follows the existing `kbEnabled` pattern. Note: the spec calls for also gating on `newsletters.manage|send` permission, but the shared frontend has no hasPermission helper today (KB/CSAT/Macros nav are admin-implicit via the surrounding is_admin section gate). Per-link permission gating can land alongside a generic hasPermission composable in a later iteration; for v1 the admin role gets both perms by default at install time, so the practical visibility is identical.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the shared Vue/Inertia admin UI for the newsletter system per
docs/superpowers/specs/2026-05-19-newsletter-system-design.md. Backend wiring follows inescalated-laravel(Wave 1).pages/Admin/Newsletters/**page tree (Index, Compose, Show, Edit, Settings, Lists, Templates)components/admin/newsletters/**building blocks (MarkdownEditor, MergeFieldDropdown, PreviewIframe, SummaryTiles, AnalyticsTiles, DeliveriesTable, ListMemberTable, DynamicFilterBuilder)escalated.features.newsletters(added toEscalatedLayout)locales/en.json(top-levelnewsletterskey)Deviations from spec
src/locales/en/<feature>.jsmodules; actual repo uses one JSON per language (en.json) with feature keys at the top level. Landed inen.json, not a new module.AdminSidebar.vuestandalone; actual repo has the admin nav inline inEscalatedLayout.vuevia anadminLinkscomputed. Added the gated entry there, following the existingkbEnabledpattern.pages/admin/newsletters/; actual convention is PascalCasepages/Admin/Newsletters/. Matched the existing convention.newsletters.manage|sendpermission gating on the sidebar entry; nohasPermissionhelper exists in the frontend today (KB/CSAT/Macros are admin-implicit). Per-link permission gating is deferred — admin role gets both perms by default at install, so practical visibility is identical.ContactFilterBuilder.vue. Shipped the JSON-textarea fallback only; will swap in the real builder when the contacts saved-view filter component lands.Test plan
v0.9.0so backend PRs can consume itReviewer: please do not auto-merge — review and merge at your discretion.