feat(post1-T-4.3): mTLS OCSP stapling on 0.7.x#36
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--tls-ocsp-staple <FILE>toboruna coordinator serve(0.7.x speculative branch)with_single_cert_with_ocsp()Depends on
T-4.2 (PR #27, already merged into 0.7.x): CRL revocation support
Implementation
ServerTlsPaths.ocsp_staple: Option<PathBuf>— optional OCSP response filefrom_optional()gains a 5thocsp_stapleargument; passing OCSP without the TLS trio is a typed startup errorbuild_server_tls()loads DER bytes and callswith_single_cert_with_ocsp(certs, key, ocsp_bytes)when the staple is set; falls back towith_single_cert()otherwiseTest plan
parse_tls_flags_ocsp_without_mtls_rejected— OCSP file without TLS trio → startup errorparse_tls_flags_ocsp_with_valid_mtls_accepted— OCSP path with all three TLS flags →ocsp_staple: Some(path)parse_tls_flags_*tests pass with updatedfrom_optionalsignaturecargo test -p boruna-cli --features serve— all passcargo clippy -p boruna-cli --features serve -- -D warnings— cleanThis change ships on 0.7.x only — not on the 1.x LTS surface.
🤖 Generated with Claude Code