Re-raise exceptions in Azure inventory builders to propagate failures#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes silent error swallowing in build_azure_resource_inventory and build_azure_cost_inventory in core/utils_azure.py.
This PR adds raise after each logger.error() call in the exception handlers so that failures (authentication errors, SQLite errors, unexpected exceptions) propagate to create_resource_inventory and create_cost_inventory in core/engine.py, which already handle them and report failure to the user. Previously, these errors were logged but silently discarded, causing the assessment to continue as if the inventory step succeeded.