Skip to content

fix(ci): switch release trigger to push on main for PyPI environment compatibility#16

Merged
eschaar merged 3 commits intomainfrom
fix/release
Apr 21, 2026
Merged

fix(ci): switch release trigger to push on main for PyPI environment compatibility#16
eschaar merged 3 commits intomainfrom
fix/release

Conversation

@eschaar
Copy link
Copy Markdown
Owner

@eschaar eschaar commented Apr 21, 2026

Summary

Release workflow and test isolation fixes for PyPI publishing.

  • Fixed release workflow trigger: switched from pull_request: closed to push: branches: [main] so the workflow runs under refs/heads/main and satisfies the PyPI environment deployment branch protection rule.
  • Fixed build job checkout missing fetch-depth: 0, required by poetry-dynamic-versioning to read git tags.
  • Fixed download-artifact version mismatch (v5v7) to align with upload-artifact@v7.
  • Simplified release workflow job names: release, build, publish.
  • Updated CHANGELOG with 1.3.1 and corrected 1.3.0 entries.

Related Issues

N/A

Validation

  • Tests pass locally
  • CI checks pass
  • Docs updated (if needed)

Release Impact

  • fix: (patch) — workflow and artifact version fixes

Copilot AI review requested due to automatic review settings April 21, 2026 23:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the GitHub Actions release workflow so PyPI publishing can run under refs/heads/main (compatible with protected PyPI environments), and updates the changelog accordingly.

Changes:

  • Switched the release workflow trigger from pull_request: closed to push on main and removed PR-only guards/checkout refs.
  • Ensured release/build/publish jobs are gated only by the computed “version changed” output and aligned artifact action versions.
  • Added a 1.3.1 changelog entry and amended 1.3.0 with a “Fixed” section.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
CHANGELOG.md Adds 1.3.1 notes and amends 1.3.0, describing workflow/test-related fixes.
.github/workflows/release.yml Updates workflow trigger and job conditions to run releases from main pushes and publish via the protected PyPI environment.

Comment thread CHANGELOG.md Outdated
Comment thread .github/workflows/release.yml Outdated
eschaar and others added 2 commits April 22, 2026 01:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@eschaar eschaar merged commit 7f47e1d into main Apr 21, 2026
12 checks passed
@eschaar eschaar deleted the fix/release branch April 21, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants