fix(ci): build release artifacts from computed tag#17
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves release packaging determinism to prevent publishing an incorrect version to PyPI by ensuring the build uses the computed release tag and adds a pre-build version guard.
Changes:
- Build job now checks out
refs/tags/${{ needs.release.outputs.version }}instead of building from a moving branch ref. - Added a “Validate package version” guard step intended to fail fast when the built version doesn’t match the computed release version.
- Updated
CHANGELOG.mdto document the fix under1.3.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
CHANGELOG.md |
Documents the release determinism/version-guard fix under the 1.3.2 entry. |
.github/workflows/release.yml |
Adjusts build checkout to the computed tag and adds a pre-build version validation step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix release packaging determinism to prevent publishing incorrect versions to PyPI.
refs/tags/${{ needs.release.outputs.version }}) instead of building from a moving branch ref.poetry version -sagainst the computed release version and fails fast on mismatch.1.3.2.Related Issues
0.0.0) instead of the intended release version.Validation
Release Impact
fix:(patch)feat:(minor)BREAKING CHANGE(major)